[jira] Commented: (GERONIMO-1333) [Daytrader] ejb module should not depend on wsappclient module

["Vincent Massol (JIRA)" <de...@geronimo.apache.org>]

    [ http://issues.apache.org/jira/browse/GERONIMO-1333?page=comments#action_12360289 ] 

Vincent Massol commented on GERONIMO-1333:
------------------------------------------

I've done some more analysis. The problem comes from TradeWebSoapProxy.java in the ejb module which uses TradeWSServices.java located in the wsapplicent module...

Several things that do not seem right:

* The ejb module should be dedicated to ejbs. If not then it's not correctly named.  Maybe a functional name like "business" would be better?
* Currently the ejb module containers the direct code (JDBC/JMS) which has nothing to do with ejbs. It could stay if the module was renamed to something like "business".
* The TradeWSServices.java class should be moved to the "business" module to remove the dependency on wsapplicent
* The ejb module should be producing 2 jars: an EJB jar and an EJB-Client jar

Thanks

> [Daytrader] ejb module should not depend on wsappclient module
> --------------------------------------------------------------
>
>          Key: GERONIMO-1333
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1333
>      Project: Geronimo
>         Type: Improvement
>   Components: sample apps
>     Versions: 1.0-M5
>     Reporter: Vincent Massol
>     Assignee: Matt Hogstrom
>      Fix For: 1.1

>
> There is dependency on the wsappclient jar in the ejb module. That doesn't look right. Does it mean the wsappclient should be split into 2 modules? I haven't investigated more but it smells like a circular depdency somewhere.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira