You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Yongzhi Chen (Code Review)" <ge...@cloudera.org> on 2019/02/14 17:38:54 UTC
[Impala-ASF-CR] IMPALA-6897: Catalog server web-ui should expose top-n tables with most number of file. The commit includes: Add functions in CatalogUsageMonitor to monitor and report the catalog usage of the tables have the most number of files Add methods to ex
Yongzhi Chen has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12483
Change subject: IMPALA-6897: Catalog server web-ui should expose top-n tables with most number of file. The commit includes: Add functions in CatalogUsageMonitor to monitor and report the catalog usage of the tables have the most number of files Add methods to ex
......................................................................
IMPALA-6897: Catalog server web-ui should expose top-n tables with most
number of file.
The commit includes:
Add functions in CatalogUsageMonitor to monitor and report the catalog
usage of the tables have the most number of files
Add methods to expose the tables with the most number of files in
catalog web UI and sorted by the files number.
Testing:
Add tests to check table usage information is in the catalogd's
catalog page.
Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
---
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog-server.h
M common/thrift/JniCatalog.thrift
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/catalog/CatalogUsageMonitor.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M tests/webserver/test_web_pages.py
M www/catalog.tmpl
9 files changed, 129 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/12483/1
--
To view, visit http://gerrit.cloudera.org:8080/12483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
Gerrit-Change-Number: 12483
Gerrit-PatchSet: 1
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
[Impala-ASF-CR] IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
Posted by "Yongzhi Chen (Code Review)" <ge...@cloudera.org>.
Hello Bharath Vissapragada, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12483
to look at the new patch set (#4).
Change subject: IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
......................................................................
IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
Add functions in CatalogUsageMonitor to monitor and report the catalog
usage of the tables have the most number of files
List the tables with the most number of files in Catalog server web-ui
and sorted by the files number.
Testing:
Add tests to check table usage information is in the catalogd's
catalog page.
Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
---
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog-server.h
M common/thrift/JniCatalog.thrift
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/catalog/CatalogUsageMonitor.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M tests/webserver/test_web_pages.py
M www/catalog.tmpl
9 files changed, 146 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/12483/4
--
To view, visit http://gerrit.cloudera.org:8080/12483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
Gerrit-Change-Number: 12483
Gerrit-PatchSet: 4
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
Posted by "Yongzhi Chen (Code Review)" <ge...@cloudera.org>.
Hello Bharath Vissapragada, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12483
to look at the new patch set (#5).
Change subject: IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
......................................................................
IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
Add functions in CatalogUsageMonitor to monitor and report the catalog
usage of the tables have the most number of files
List the tables with the most number of files in Catalog server web-ui
and sorted by the files number.
Testing:
Add tests to check table usage information is in the catalogd's
catalog page.
Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
---
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog-server.h
M common/thrift/JniCatalog.thrift
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/catalog/CatalogUsageMonitor.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M tests/webserver/test_web_pages.py
M www/catalog.tmpl
9 files changed, 147 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/12483/5
--
To view, visit http://gerrit.cloudera.org:8080/12483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
Gerrit-Change-Number: 12483
Gerrit-PatchSet: 5
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
[Impala-ASF-CR] IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
Posted by "Yongzhi Chen (Code Review)" <ge...@cloudera.org>.
Hello Bharath Vissapragada, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12483
to look at the new patch set (#8).
Change subject: IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
......................................................................
IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
Add functions in CatalogUsageMonitor to monitor and report the catalog
usage of the tables have the most number of files
List the tables with the most number of files in Catalog server web-ui
and sorted by the files number.
Testing:
Add tests to check table usage information is in the catalogd's
catalog page.
Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
---
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog-server.h
M common/thrift/JniCatalog.thrift
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/catalog/CatalogUsageMonitor.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M tests/webserver/test_web_pages.py
M www/catalog.tmpl
9 files changed, 162 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/12483/8
--
To view, visit http://gerrit.cloudera.org:8080/12483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
Gerrit-Change-Number: 12483
Gerrit-PatchSet: 8
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
[Impala-ASF-CR] IMPALA-6897: Catalog server web-ui should expose top-n tables with most number of file. The commit includes: Add functions in CatalogUsageMonitor to monitor and report the catalog usage of the tables have the most number of files Add methods to ex
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12483 )
Change subject: IMPALA-6897: Catalog server web-ui should expose top-n tables with most number of file. The commit includes: Add functions in CatalogUsageMonitor to monitor and report the catalog usage of the tables have the most number of files Add methods to ex
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2129/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
Gerrit-Change-Number: 12483
Gerrit-PatchSet: 3
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Feb 2019 20:20:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
Posted by "Yongzhi Chen (Code Review)" <ge...@cloudera.org>.
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/12483 )
Change subject: IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
......................................................................
Patch Set 5:
(6 comments)
Submit new patch to address the new review issues.
http://gerrit.cloudera.org:8080/#/c/12483/5/be/src/catalog/catalog-server.h
File be/src/catalog/catalog-server.h:
http://gerrit.cloudera.org:8080/#/c/12483/5/be/src/catalog/catalog-server.h@203
PS5, Line 203: most_num_files_tables
> Should we change to high_file_count in all the places? ( including the thri
Done
http://gerrit.cloudera.org:8080/#/c/12483/5/be/src/catalog/catalog-server.cc
File be/src/catalog/catalog-server.cc:
http://gerrit.cloudera.org:8080/#/c/12483/5/be/src/catalog/catalog-server.cc@528
PS5, Line 528: num_most_tables
> num_high_file_count_tbls?
Done
http://gerrit.cloudera.org:8080/#/c/12483/5/fe/src/main/java/org/apache/impala/catalog/CatalogUsageMonitor.java
File fe/src/main/java/org/apache/impala/catalog/CatalogUsageMonitor.java:
http://gerrit.cloudera.org:8080/#/c/12483/5/fe/src/main/java/org/apache/impala/catalog/CatalogUsageMonitor.java@41
PS5, Line 41: mostFilesTables_
> highFileCountTables_..?
Done
http://gerrit.cloudera.org:8080/#/c/12483/5/fe/src/main/java/org/apache/impala/catalog/CatalogUsageMonitor.java@72
PS5, Line 72: updateMostFilesTables
> updateHighFileCountTables..()
Done
http://gerrit.cloudera.org:8080/#/c/12483/5/fe/src/main/java/org/apache/impala/catalog/CatalogUsageMonitor.java@88
PS5, Line 88: getMostFilesTables
> getHigh...
Done
http://gerrit.cloudera.org:8080/#/c/12483/5/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:
http://gerrit.cloudera.org:8080/#/c/12483/5/tests/webserver/test_web_pages.py@294
PS5, Line 294: response = self.get_and_check_status(self.CATALOG_URL,
: "Tables with Most Number of Files", ports_to_test=self.CATALOG_TEST_PORT)
: list_file_str = re.search('<table id="most-num-files-tables"( .*?)</table>',
: response[0].text, re.MULTILINE | re.DOTALL)
: target_metric = "%s.%s-metric" % (db_name, tbl_name)
: assert target_metric in list_file_str.group(0)
: list_files = re.findall('<tr>(.*?)</tr>', list_file_str.group(0),
: re.MULTILINE | re.DOTALL)
: for trow in list_files:
: if re.search(target_metric, trow) is not None:
: nfiles = re.search('(?<=\<td\>)\d+', trow)
: assert nfiles.group(0) == numfiles
> This looks flaky. Can we instead validate the JSON backing this page?
It just gets information from a html table, it is not flaky. At least it is not more flaky than json. (Both need a structure to store the layers of content, and the html structure in this page is much easier to understand for human being: The high file count table has several rows, each row has 3 columns, the second column provide the num_file.
--
To view, visit http://gerrit.cloudera.org:8080/12483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
Gerrit-Change-Number: 12483
Gerrit-PatchSet: 5
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Feb 2019 22:02:15 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6897: Catalog server web-ui should expose top-n tables with most number of file. The commit includes: Add functions in CatalogUsageMonitor to monitor and report the catalog usage of the tables have the most number of files Add methods to ex
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12483 )
Change subject: IMPALA-6897: Catalog server web-ui should expose top-n tables with most number of file. The commit includes: Add functions in CatalogUsageMonitor to monitor and report the catalog usage of the tables have the most number of files Add methods to ex
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2128/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
Gerrit-Change-Number: 12483
Gerrit-PatchSet: 2
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Feb 2019 18:44:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12483 )
Change subject: IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
......................................................................
Patch Set 9:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2285/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
Gerrit-Change-Number: 12483
Gerrit-PatchSet: 9
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 23:15:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12483 )
Change subject: IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
......................................................................
IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
Add functions in CatalogUsageMonitor to monitor and report the catalog
usage of the tables have the most number of files
List the tables with the most number of files in Catalog server web-ui
and sorted by the files number.
Testing:
Add tests to check table usage information is in the catalogd's
catalog page.
Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
Reviewed-on: http://gerrit.cloudera.org:8080/12483
Reviewed-by: Bharath Vissapragada <bh...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog-server.h
M common/thrift/JniCatalog.thrift
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/catalog/CatalogUsageMonitor.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M tests/webserver/test_web_pages.py
M www/catalog.tmpl
9 files changed, 162 insertions(+), 6 deletions(-)
Approvals:
Bharath Vissapragada: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
Gerrit-Change-Number: 12483
Gerrit-PatchSet: 10
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
[Impala-ASF-CR] IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12483 )
Change subject: IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
......................................................................
Patch Set 6:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/12483/6/be/src/catalog/catalog-server.cc
File be/src/catalog/catalog-server.cc:
http://gerrit.cloudera.org:8080/#/c/12483/6/be/src/catalog/catalog-server.cc@508
PS6, Line 508: most_num_files_tables
update
http://gerrit.cloudera.org:8080/#/c/12483/6/be/src/catalog/catalog-server.cc@530
PS6, Line 530: num_most_files_tables
update
http://gerrit.cloudera.org:8080/#/c/12483/5/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:
http://gerrit.cloudera.org:8080/#/c/12483/5/tests/webserver/test_web_pages.py@294
PS5, Line 294: response = self.get_and_check_status(self.CATALOG_URL,
: "Tables with Most Number of Files", ports_to_test=self.CATALOG_TEST_PORT)
: list_file_str = re.search('<table id="most-num-files-tables"( .*?)</table>',
: response[0].text, re.MULTILINE | re.DOTALL)
: target_metric = "%s.%s-metric" % (db_name, tbl_name)
: # Check the db table is in the list
: assert target_metric in list_file_str.group(0)
: list_files = re.findall('<tr>(.*?)</tr>', list_file_str.group(0),
: re.MULTILINE | re.DOTALL)
: for trow in list_files:
: # Find the entry for the db table and verify its file count.
: if re.search(target_metric, trow) is
> It just gets information from a html table, it is not flaky. At least it is
Sorry, should've been more clear. The reason I think this is flaky is because of the regexes. I think parsing a JSON is much more human-readable than parsing a html page with regexes.
http://gerrit.cloudera.org:8080/#/c/12483/6/www/catalog.tmpl
File www/catalog.tmpl:
http://gerrit.cloudera.org:8080/#/c/12483/6/www/catalog.tmpl@104
PS6, Line 104: most_num_files_tables
update
http://gerrit.cloudera.org:8080/#/c/12483/6/www/catalog.tmpl@108
PS6, Line 108: num_most_files_tables
Update
http://gerrit.cloudera.org:8080/#/c/12483/6/www/catalog.tmpl@112
PS6, Line 112: most-num-files-tables
high-file-count...
http://gerrit.cloudera.org:8080/#/c/12483/6/www/catalog.tmpl@136
PS6, Line 136: most-num-files-tables
updatw
--
To view, visit http://gerrit.cloudera.org:8080/12483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
Gerrit-Change-Number: 12483
Gerrit-PatchSet: 6
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Feb 2019 22:35:27 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6897: Catalog server web-ui should expose top-n tables with most number of file. The commit includes: Add functions in CatalogUsageMonitor to monitor and report the catalog usage of the tables have the most number of files Add methods to ex
Posted by "Yongzhi Chen (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12483
to look at the new patch set (#3).
Change subject: IMPALA-6897: Catalog server web-ui should expose top-n tables with most number of file. The commit includes: Add functions in CatalogUsageMonitor to monitor and report the catalog usage of the tables have the most number of files Add methods to ex
......................................................................
IMPALA-6897: Catalog server web-ui should expose top-n tables with most
number of file.
The commit includes:
Add functions in CatalogUsageMonitor to monitor and report the catalog
usage of the tables have the most number of files
Add methods to expose the tables with the most number of files in
catalog web UI and sorted by the files number.
Testing:
Add tests to check table usage information is in the catalogd's
catalog page.
Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
---
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog-server.h
M common/thrift/JniCatalog.thrift
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/catalog/CatalogUsageMonitor.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M tests/webserver/test_web_pages.py
M www/catalog.tmpl
9 files changed, 130 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/12483/3
--
To view, visit http://gerrit.cloudera.org:8080/12483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
Gerrit-Change-Number: 12483
Gerrit-PatchSet: 3
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12483 )
Change subject: IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
......................................................................
Patch Set 4:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/12483/4/be/src/catalog/catalog-server.cc
File be/src/catalog/catalog-server.cc:
http://gerrit.cloudera.org:8080/#/c/12483/4/be/src/catalog/catalog-server.cc@526
PS4, Line 526: document->AddMember("most_num_files_tables", most_num_files_tables, document->GetAllocator());
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/12483/4/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:
http://gerrit.cloudera.org:8080/#/c/12483/4/tests/webserver/test_web_pages.py@271
PS4, Line 271: r
flake8: F841 local variable 'response' is assigned to but never used
http://gerrit.cloudera.org:8080/#/c/12483/4/tests/webserver/test_web_pages.py@294
PS4, Line 294:
flake8: E222 multiple spaces after operator
--
To view, visit http://gerrit.cloudera.org:8080/12483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
Gerrit-Change-Number: 12483
Gerrit-PatchSet: 4
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Feb 2019 14:59:14 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12483 )
Change subject: IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
......................................................................
Patch Set 7: Code-Review+2
(1 comment)
If you could rebase on to the master, I can submit it for a GVO.
http://gerrit.cloudera.org:8080/#/c/12483/7/fe/src/main/java/org/apache/impala/catalog/Table.java
File fe/src/main/java/org/apache/impala/catalog/Table.java:
http://gerrit.cloudera.org:8080/#/c/12483/7/fe/src/main/java/org/apache/impala/catalog/Table.java@174
PS7, Line 174: public void initMetrics() {
newline
--
To view, visit http://gerrit.cloudera.org:8080/12483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
Gerrit-Change-Number: 12483
Gerrit-PatchSet: 7
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 22:18:20 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
Posted by "Yongzhi Chen (Code Review)" <ge...@cloudera.org>.
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/12483 )
Change subject: IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
......................................................................
Patch Set 7:
(6 comments)
submit patch 7 to fix names and add comments.
http://gerrit.cloudera.org:8080/#/c/12483/6/be/src/catalog/catalog-server.cc
File be/src/catalog/catalog-server.cc:
http://gerrit.cloudera.org:8080/#/c/12483/6/be/src/catalog/catalog-server.cc@508
PS6, Line 508: high_filecount_tbls(k
> update
Done
http://gerrit.cloudera.org:8080/#/c/12483/6/be/src/catalog/catalog-server.cc@530
PS6, Line 530: num_high_file_count_t
> update
Done
http://gerrit.cloudera.org:8080/#/c/12483/6/www/catalog.tmpl
File www/catalog.tmpl:
http://gerrit.cloudera.org:8080/#/c/12483/6/www/catalog.tmpl@104
PS6, Line 104: high_file_count_table
> update
Done
http://gerrit.cloudera.org:8080/#/c/12483/6/www/catalog.tmpl@108
PS6, Line 108: num_high_file_count_t
> Update
Done
http://gerrit.cloudera.org:8080/#/c/12483/6/www/catalog.tmpl@112
PS6, Line 112: high-file-count-table
> high-file-count...
Done
http://gerrit.cloudera.org:8080/#/c/12483/6/www/catalog.tmpl@136
PS6, Line 136: high-file-count-table
> updatw
Done
--
To view, visit http://gerrit.cloudera.org:8080/12483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
Gerrit-Change-Number: 12483
Gerrit-PatchSet: 7
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Feb 2019 13:13:04 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
Posted by "Yongzhi Chen (Code Review)" <ge...@cloudera.org>.
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/12483 )
Change subject: IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12483/5/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:
http://gerrit.cloudera.org:8080/#/c/12483/5/tests/webserver/test_web_pages.py@294
PS5, Line 294: response = self.get_and_check_status(self.CATALOG_URL,
: "Tables with Most Number of Files", ports_to_test=self.CATALOG_TEST_PORT)
: list_file_str = re.search('<table id="most-num-files-tables"( .*?)</table>',
: response[0].text, re.MULTILINE | re.DOTALL)
: target_metric = "%s.%s-metric" % (db_name, tbl_name)
: assert target_metric in list_file_str.group(0)
: list_files = re.findall('<tr>(.*?)</tr>', list_file_str.group(0),
: re.MULTILINE | re.DOTALL)
: for trow in list_files:
: if re.search(target_metric, trow) is not None:
: nfiles = re.search('(?<=\<td\>)\d+', trow)
: assert nfiles.group(0) == numfiles
> Sorry, should've been more clear. The reason I think this is flaky is becau
I added more comment, hope that make it better. This test is real web page test not just for the json data. This test is more like showing the screenshot.
--
To view, visit http://gerrit.cloudera.org:8080/12483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
Gerrit-Change-Number: 12483
Gerrit-PatchSet: 5
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Feb 2019 23:45:03 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6897: Catalog server web-ui should expose top-n tables with most number of file. The commit includes: Add functions in CatalogUsageMonitor to monitor and report the catalog usage of the tables have the most number of files Add methods to ex
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12483 )
Change subject: IMPALA-6897: Catalog server web-ui should expose top-n tables with most number of file. The commit includes: Add functions in CatalogUsageMonitor to monitor and report the catalog usage of the tables have the most number of files Add methods to ex
......................................................................
Patch Set 3:
(10 comments)
Can you paste a screenshot of how this looks like?
http://gerrit.cloudera.org:8080/#/c/12483/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12483/3//COMMIT_MSG@7
PS3, Line 7: IMPALA-6897: Catalog server web-ui should expose top-n tables with most
: number of file.
nit: rephrase to limit it to 72 chars.
http://gerrit.cloudera.org:8080/#/c/12483/3//COMMIT_MSG@10
PS3, Line 10: Add functions in CatalogUsageMonitor to monitor and report the catalog
nit: Indent these better. Also, try to avoid implementation detail and summarize the functionality that was added?
http://gerrit.cloudera.org:8080/#/c/12483/3/be/src/catalog/catalog-server.h
File be/src/catalog/catalog-server.h:
http://gerrit.cloudera.org:8080/#/c/12483/3/be/src/catalog/catalog-server.h@187
PS3, Line 187: .
Update?
http://gerrit.cloudera.org:8080/#/c/12483/3/common/thrift/JniCatalog.thrift
File common/thrift/JniCatalog.thrift:
http://gerrit.cloudera.org:8080/#/c/12483/3/common/thrift/JniCatalog.thrift@710
PS3, Line 710: that table has
nit:...in this table.
http://gerrit.cloudera.org:8080/#/c/12483/3/common/thrift/JniCatalog.thrift@711
PS3, Line 711: 4: optional i64 num_files
nit: Clarify that for partitioned tables, this includes file counts across all the partitions?
http://gerrit.cloudera.org:8080/#/c/12483/3/common/thrift/JniCatalog.thrift@724
PS3, Line 724: most_num_files_tables
rename to something like high_file_count_tables or something? (or any other better name you can think of)
http://gerrit.cloudera.org:8080/#/c/12483/3/fe/src/main/java/org/apache/impala/catalog/Table.java
File fe/src/main/java/org/apache/impala/catalog/Table.java:
http://gerrit.cloudera.org:8080/#/c/12483/3/fe/src/main/java/org/apache/impala/catalog/Table.java@152
PS3, Line 152: getNumOfFiles
getNumFiles()?
http://gerrit.cloudera.org:8080/#/c/12483/3/fe/src/main/java/org/apache/impala/catalog/Table.java@168
PS3, Line 168: public void setNumOfFiles(long numOfFiles) {
: numOfFiles_.set(numOfFiles);
: if (!isStoredInImpaladCatalogCache()) {
: CatalogUsageMonitor.INSTANCE.updateMostFilesTables(this);
: }
: }
This does not make sense for non-HDFS tables. Instead do this in HdfsTable class?
http://gerrit.cloudera.org:8080/#/c/12483/3/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:
http://gerrit.cloudera.org:8080/#/c/12483/3/tests/webserver/test_web_pages.py@271
PS3, Line 271: es")
Could you also validate the number of files?
http://gerrit.cloudera.org:8080/#/c/12483/3/tests/webserver/test_web_pages.py@272
PS3, Line 272: def __test_catalog_object(self, db_name, tbl_name):
newline
--
To view, visit http://gerrit.cloudera.org:8080/12483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
Gerrit-Change-Number: 12483
Gerrit-PatchSet: 3
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Feb 2019 18:22:19 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12483 )
Change subject: IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
......................................................................
Patch Set 9: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
Gerrit-Change-Number: 12483
Gerrit-PatchSet: 9
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Feb 2019 03:15:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6897: Catalog server web-ui should expose top-n tables with most number of file. The commit includes: Add functions in CatalogUsageMonitor to monitor and report the catalog usage of the tables have the most number of files Add methods to ex
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12483 )
Change subject: IMPALA-6897: Catalog server web-ui should expose top-n tables with most number of file. The commit includes: Add functions in CatalogUsageMonitor to monitor and report the catalog usage of the tables have the most number of files Add methods to ex
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12483/2/be/src/catalog/catalog-server.cc
File be/src/catalog/catalog-server.cc:
http://gerrit.cloudera.org:8080/#/c/12483/2/be/src/catalog/catalog-server.cc@526
PS2, Line 526: document->AddMember("most_num_files_tables", most_num_files_tables,
line has trailing whitespace
--
To view, visit http://gerrit.cloudera.org:8080/12483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
Gerrit-Change-Number: 12483
Gerrit-PatchSet: 2
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Feb 2019 17:58:30 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6897: Catalog server web-ui should expose top-n tables with most number of file. The commit includes: Add functions in CatalogUsageMonitor to monitor and report the catalog usage of the tables have the most number of files Add methods to ex
Posted by "Yongzhi Chen (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12483
to look at the new patch set (#2).
Change subject: IMPALA-6897: Catalog server web-ui should expose top-n tables with most number of file. The commit includes: Add functions in CatalogUsageMonitor to monitor and report the catalog usage of the tables have the most number of files Add methods to ex
......................................................................
IMPALA-6897: Catalog server web-ui should expose top-n tables with most
number of file.
The commit includes:
Add functions in CatalogUsageMonitor to monitor and report the catalog
usage of the tables have the most number of files
Add methods to expose the tables with the most number of files in
catalog web UI and sorted by the files number.
Testing:
Add tests to check table usage information is in the catalogd's
catalog page.
Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
---
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog-server.h
M common/thrift/JniCatalog.thrift
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/catalog/CatalogUsageMonitor.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M tests/webserver/test_web_pages.py
M www/catalog.tmpl
9 files changed, 130 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/12483/2
--
To view, visit http://gerrit.cloudera.org:8080/12483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
Gerrit-Change-Number: 12483
Gerrit-PatchSet: 2
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12483 )
Change subject: IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
......................................................................
Patch Set 5:
(6 comments)
Bunch of naming nits. Otherwise lgtm.
http://gerrit.cloudera.org:8080/#/c/12483/5/be/src/catalog/catalog-server.h
File be/src/catalog/catalog-server.h:
http://gerrit.cloudera.org:8080/#/c/12483/5/be/src/catalog/catalog-server.h@203
PS5, Line 203: most_num_files_tables
Should we change to high_file_count in all the places? ( including the thrift spec, variables etc. to be consistent).
http://gerrit.cloudera.org:8080/#/c/12483/5/be/src/catalog/catalog-server.cc
File be/src/catalog/catalog-server.cc:
http://gerrit.cloudera.org:8080/#/c/12483/5/be/src/catalog/catalog-server.cc@528
PS5, Line 528: num_most_tables
num_high_file_count_tbls?
http://gerrit.cloudera.org:8080/#/c/12483/5/fe/src/main/java/org/apache/impala/catalog/CatalogUsageMonitor.java
File fe/src/main/java/org/apache/impala/catalog/CatalogUsageMonitor.java:
http://gerrit.cloudera.org:8080/#/c/12483/5/fe/src/main/java/org/apache/impala/catalog/CatalogUsageMonitor.java@41
PS5, Line 41: mostFilesTables_
highFileCountTables_..?
http://gerrit.cloudera.org:8080/#/c/12483/5/fe/src/main/java/org/apache/impala/catalog/CatalogUsageMonitor.java@72
PS5, Line 72: updateMostFilesTables
updateHighFileCountTables..()
http://gerrit.cloudera.org:8080/#/c/12483/5/fe/src/main/java/org/apache/impala/catalog/CatalogUsageMonitor.java@88
PS5, Line 88: getMostFilesTables
getHigh...
http://gerrit.cloudera.org:8080/#/c/12483/5/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:
http://gerrit.cloudera.org:8080/#/c/12483/5/tests/webserver/test_web_pages.py@294
PS5, Line 294: response = self.get_and_check_status(self.CATALOG_URL,
: "Tables with Most Number of Files", ports_to_test=self.CATALOG_TEST_PORT)
: list_file_str = re.search('<table id="most-num-files-tables"( .*?)</table>',
: response[0].text, re.MULTILINE | re.DOTALL)
: target_metric = "%s.%s-metric" % (db_name, tbl_name)
: assert target_metric in list_file_str.group(0)
: list_files = re.findall('<tr>(.*?)</tr>', list_file_str.group(0),
: re.MULTILINE | re.DOTALL)
: for trow in list_files:
: if re.search(target_metric, trow) is not None:
: nfiles = re.search('(?<=\<td\>)\d+', trow)
: assert nfiles.group(0) == numfiles
This looks flaky. Can we instead validate the JSON backing this page?
You can get that by polling /catalog?json
--
To view, visit http://gerrit.cloudera.org:8080/12483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
Gerrit-Change-Number: 12483
Gerrit-PatchSet: 5
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Feb 2019 19:20:45 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
Posted by "Yongzhi Chen (Code Review)" <ge...@cloudera.org>.
Hello Bharath Vissapragada, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12483
to look at the new patch set (#9).
Change subject: IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
......................................................................
IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
Add functions in CatalogUsageMonitor to monitor and report the catalog
usage of the tables have the most number of files
List the tables with the most number of files in Catalog server web-ui
and sorted by the files number.
Testing:
Add tests to check table usage information is in the catalogd's
catalog page.
Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
---
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog-server.h
M common/thrift/JniCatalog.thrift
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/catalog/CatalogUsageMonitor.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M tests/webserver/test_web_pages.py
M www/catalog.tmpl
9 files changed, 162 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/12483/9
--
To view, visit http://gerrit.cloudera.org:8080/12483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
Gerrit-Change-Number: 12483
Gerrit-PatchSet: 9
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
[Impala-ASF-CR] IMPALA-6897: Catalog server web-ui should expose top-n tables with most number of file. The commit includes: Add functions in CatalogUsageMonitor to monitor and report the catalog usage of the tables have the most number of files Add methods to ex
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12483 )
Change subject: IMPALA-6897: Catalog server web-ui should expose top-n tables with most number of file. The commit includes: Add functions in CatalogUsageMonitor to monitor and report the catalog usage of the tables have the most number of files Add methods to ex
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2127/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
Gerrit-Change-Number: 12483
Gerrit-PatchSet: 1
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Feb 2019 18:21:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12483 )
Change subject: IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
......................................................................
Patch Set 8:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2283/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
Gerrit-Change-Number: 12483
Gerrit-PatchSet: 8
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 23:00:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12483 )
Change subject: IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2170/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
Gerrit-Change-Number: 12483
Gerrit-PatchSet: 4
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Feb 2019 15:42:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12483 )
Change subject: IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
......................................................................
Patch Set 6:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2184/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
Gerrit-Change-Number: 12483
Gerrit-PatchSet: 6
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Feb 2019 22:26:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12483 )
Change subject: IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
......................................................................
Patch Set 7:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2195/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
Gerrit-Change-Number: 12483
Gerrit-PatchSet: 7
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Feb 2019 13:54:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12483 )
Change subject: IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
......................................................................
Patch Set 8:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12483/8/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:
http://gerrit.cloudera.org:8080/#/c/12483/8/tests/webserver/test_web_pages.py@27
PS8, Line 27: import re
flake8: F811 redefinition of unused 're' from line 25
--
To view, visit http://gerrit.cloudera.org:8080/12483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
Gerrit-Change-Number: 12483
Gerrit-PatchSet: 8
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 22:31:50 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6897: Catalog server web-ui should expose top-n tables with most number of file. The commit includes: Add functions in CatalogUsageMonitor to monitor and report the catalog usage of the tables have the most number of files Add methods to ex
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12483 )
Change subject: IMPALA-6897: Catalog server web-ui should expose top-n tables with most number of file. The commit includes: Add functions in CatalogUsageMonitor to monitor and report the catalog usage of the tables have the most number of files Add methods to ex
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12483/1/be/src/catalog/catalog-server.cc
File be/src/catalog/catalog-server.cc:
http://gerrit.cloudera.org:8080/#/c/12483/1/be/src/catalog/catalog-server.cc@526
PS1, Line 526: document->AddMember("most_num_files_tables", most_num_files_tables, document->GetAllocator());
line too long (96 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/12483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
Gerrit-Change-Number: 12483
Gerrit-PatchSet: 1
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Feb 2019 17:39:52 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
Posted by "Yongzhi Chen (Code Review)" <ge...@cloudera.org>.
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/12483 )
Change subject: IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
......................................................................
Patch Set 4:
(9 comments)
Patch 4 addresses most issues. Not sure how to attach a screenshot with commit message.
http://gerrit.cloudera.org:8080/#/c/12483/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12483/3//COMMIT_MSG@7
PS3, Line 7: IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
:
> nit: rephrase to limit it to 72 chars.
Done
http://gerrit.cloudera.org:8080/#/c/12483/3//COMMIT_MSG@10
PS3, Line 10: usage of the tables have the most number of files
> nit: Indent these better. Also, try to avoid implementation detail and summ
Done
http://gerrit.cloudera.org:8080/#/c/12483/3/be/src/catalog/catalog-server.h
File be/src/catalog/catalog-server.h:
http://gerrit.cloudera.org:8080/#/c/12483/3/be/src/catalog/catalog-server.h@187
PS3, Line 187: h
> Update?
Done
http://gerrit.cloudera.org:8080/#/c/12483/3/common/thrift/JniCatalog.thrift
File common/thrift/JniCatalog.thrift:
http://gerrit.cloudera.org:8080/#/c/12483/3/common/thrift/JniCatalog.thrift@710
PS3, Line 710: in this table.
> nit:...in this table.
Done
http://gerrit.cloudera.org:8080/#/c/12483/3/common/thrift/JniCatalog.thrift@711
PS3, Line 711: // across all the partitions.
> nit: Clarify that for partitioned tables, this includes file counts across
Done
http://gerrit.cloudera.org:8080/#/c/12483/3/fe/src/main/java/org/apache/impala/catalog/Table.java
File fe/src/main/java/org/apache/impala/catalog/Table.java:
http://gerrit.cloudera.org:8080/#/c/12483/3/fe/src/main/java/org/apache/impala/catalog/Table.java@152
PS3, Line 152: getNumFiles()
> getNumFiles()?
Done
http://gerrit.cloudera.org:8080/#/c/12483/3/fe/src/main/java/org/apache/impala/catalog/Table.java@168
PS3, Line 168: public void setNumFiles(long numFiles) {
: numFiles_.set(numFiles);
: if (!isStoredInImpaladCatalogCache()) {
: CatalogUsageMonitor.INSTANCE.updateMostFilesTables(this);
: }
: }
> This does not make sense for non-HDFS tables. Instead do this in HdfsTable
This is only called in hdfs for now. But it follows the same pattern as estimatedMetadataSize(memory usage) for CatalogUsageMonitor. It is easier to extend in the future if more than hdfs is supported.
http://gerrit.cloudera.org:8080/#/c/12483/3/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:
http://gerrit.cloudera.org:8080/#/c/12483/3/tests/webserver/test_web_pages.py@271
PS3, Line 271: allt
> Could you also validate the number of files?
Done
http://gerrit.cloudera.org:8080/#/c/12483/3/tests/webserver/test_web_pages.py@272
PS3, Line 272:
> newline
Done
--
To view, visit http://gerrit.cloudera.org:8080/12483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
Gerrit-Change-Number: 12483
Gerrit-PatchSet: 4
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Feb 2019 14:48:10 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
Posted by "Yongzhi Chen (Code Review)" <ge...@cloudera.org>.
Hello Bharath Vissapragada, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12483
to look at the new patch set (#6).
Change subject: IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
......................................................................
IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
Add functions in CatalogUsageMonitor to monitor and report the catalog
usage of the tables have the most number of files
List the tables with the most number of files in Catalog server web-ui
and sorted by the files number.
Testing:
Add tests to check table usage information is in the catalogd's
catalog page.
Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
---
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog-server.h
M common/thrift/JniCatalog.thrift
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/catalog/CatalogUsageMonitor.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M tests/webserver/test_web_pages.py
M www/catalog.tmpl
9 files changed, 149 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/12483/6
--
To view, visit http://gerrit.cloudera.org:8080/12483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
Gerrit-Change-Number: 12483
Gerrit-PatchSet: 6
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
[Impala-ASF-CR] IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12483 )
Change subject: IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2172/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
Gerrit-Change-Number: 12483
Gerrit-PatchSet: 5
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Feb 2019 18:48:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
Posted by "Yongzhi Chen (Code Review)" <ge...@cloudera.org>.
Hello Bharath Vissapragada, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12483
to look at the new patch set (#7).
Change subject: IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
......................................................................
IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
Add functions in CatalogUsageMonitor to monitor and report the catalog
usage of the tables have the most number of files
List the tables with the most number of files in Catalog server web-ui
and sorted by the files number.
Testing:
Add tests to check table usage information is in the catalogd's
catalog page.
Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
---
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog-server.h
M common/thrift/JniCatalog.thrift
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/catalog/CatalogUsageMonitor.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M tests/webserver/test_web_pages.py
M www/catalog.tmpl
9 files changed, 150 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/12483/7
--
To view, visit http://gerrit.cloudera.org:8080/12483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
Gerrit-Change-Number: 12483
Gerrit-PatchSet: 7
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
[Impala-ASF-CR] IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12483 )
Change subject: IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
......................................................................
Patch Set 9:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3846/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
Gerrit-Change-Number: 12483
Gerrit-PatchSet: 9
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 23:08:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12483 )
Change subject: IMPALA-6897: Catalog web-ui exposes top-n tables with most num of files.
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04df5756641bb10dbb86d813b8001c4a04d7dc9b
Gerrit-Change-Number: 12483
Gerrit-PatchSet: 9
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 23:07:55 +0000
Gerrit-HasComments: No