You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/05/07 05:36:50 UTC

[GitHub] [incubator-pinot] mayankshriv commented on pull request #5343: Fix ByteBuffer incompatible issue

mayankshriv commented on pull request #5343:
URL: https://github.com/apache/incubator-pinot/pull/5343#issuecomment-625039325


   > If we have to cast is everywhere why not change the type of the variable?
   
   +1, casting seems very hacky.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org