You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Alex Kozhenkov <wi...@gmail.com> on 2021/03/02 13:04:19 UTC

Allow arrays in node attributes for thin clients

Hi guys!

We have a restriction to filter array values from node attributes if it is
not "org.apache.ignite.features" (GridTopologyCommandHandler.java:313).

It will be useful to allow arrays for any attribute with suffix ".features"
for external modules. Otherwise, these attributes are not allowed from
GridClient.

What do you think about allowing it?

Re: Allow arrays in node attributes for thin clients

Posted by Alex Kozhenkov <wi...@gmail.com>.
OK, I got it.
Yes, we can use String instead.

вт, 2 мар. 2021 г. в 18:27, Pavel Tupitsyn <pt...@apache.org>:

> I think we agreed to make thin client attributes String-only [1]
> However, this does not seem to be the case right now.
>
> Anyway, I'd like to avoid complicating the protocol even further with magic
> suffixes.
> Can we simply use a String instead of an array?
>
> [1]
>
> http://apache-ignite-developers.2346864.n4.nabble.com/Add-user-attributes-to-thin-clients-td45273.html
>
> On Tue, Mar 2, 2021 at 4:04 PM Alex Kozhenkov <wi...@gmail.com> wrote:
>
> > Hi guys!
> >
> > We have a restriction to filter array values from node attributes if it
> is
> > not "org.apache.ignite.features" (GridTopologyCommandHandler.java:313).
> >
> > It will be useful to allow arrays for any attribute with suffix
> ".features"
> > for external modules. Otherwise, these attributes are not allowed from
> > GridClient.
> >
> > What do you think about allowing it?
> >
>

Re: Allow arrays in node attributes for thin clients

Posted by Pavel Tupitsyn <pt...@apache.org>.
I think we agreed to make thin client attributes String-only [1]
However, this does not seem to be the case right now.

Anyway, I'd like to avoid complicating the protocol even further with magic
suffixes.
Can we simply use a String instead of an array?

[1]
http://apache-ignite-developers.2346864.n4.nabble.com/Add-user-attributes-to-thin-clients-td45273.html

On Tue, Mar 2, 2021 at 4:04 PM Alex Kozhenkov <wi...@gmail.com> wrote:

> Hi guys!
>
> We have a restriction to filter array values from node attributes if it is
> not "org.apache.ignite.features" (GridTopologyCommandHandler.java:313).
>
> It will be useful to allow arrays for any attribute with suffix ".features"
> for external modules. Otherwise, these attributes are not allowed from
> GridClient.
>
> What do you think about allowing it?
>