You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by bzz <gi...@git.apache.org> on 2015/11/24 03:26:04 UTC

[GitHub] incubator-zeppelin pull request: ZEPPELIN-413: Fix ability to link...

GitHub user bzz opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/464

    ZEPPELIN-413: Fix ability to link a single paragraph

    Fixes [ZEPPELIN-413](https://issues.apache.org/jira/browse/ZEPPELIN-413)
    
    Relevant changes in `setNoteContent ` handler
    
    Test plan:
     - Link a paragraph from Zeppelin Tutorial i.e [/#/notebook/2A94M5J1Z/paragraph/20150210-015302_1492795503?asIframe](http://localhost:9000/#/notebook/2A94M5J1Z/paragraph/20150210-015302_1492795503?asIframe)
    
    \cc @minahlee for review 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bzz/incubator-zeppelin bugfix/link-par-ZEPPELIN-413

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/464.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #464
    
----
commit 9425a97567b8be9c3d5b8799f02d6c6574a8cb3a
Author: Alexander Bezzubov <bz...@apache.org>
Date:   2015-11-24T02:16:37Z

    ZEPPELIN-413: fix tabs and formatting

commit d5f7675d6ed70902416853effad67913b460a611
Author: Alexander Bezzubov <bz...@apache.org>
Date:   2015-11-24T02:20:18Z

    ZEPPELIN-413: restore ability to link single paragraph

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: ZEPPELIN-413: Fix ability to link...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/464


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: ZEPPELIN-413: Fix ability to link...

Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/464#issuecomment-159158086
  
    Works well, LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: ZEPPELIN-413: Fix ability to link...

Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/464#issuecomment-159147970
  
    Tested and LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: ZEPPELIN-413: Fix ability to link...

Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/464#issuecomment-159150182
  
    :+1: LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: ZEPPELIN-413: Fix ability to link...

Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/464#issuecomment-159147679
  
    Tried it, looks good


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: ZEPPELIN-413: Fix ability to link...

Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/464#issuecomment-159155072
  
    Thank you for the reviews!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---