[GitHub] [cassandra] maedhroz commented on a diff in pull request #2329: CASSANDRA-18521: Unify CQLTester#waitForIndex and SAITester#waitForIndexQueryable

["maedhroz (via GitHub)" <gi...@apache.org>]

maedhroz commented on code in PR #2329:
URL: https://github.com/apache/cassandra/pull/2329#discussion_r1192816466


##########
test/unit/org/apache/cassandra/cql3/validation/entities/SecondaryIndexOnMapEntriesTest.java:
##########
@@ -230,7 +230,7 @@ public void testShouldRejectQueriesForNullEntries() throws Throwable
     public void testShouldTreatQueriesAgainstFrozenMapIndexesAsInvalid() throws Throwable
     {
         createTable("CREATE TABLE %s (k TEXT PRIMARY KEY, v FROZEN<MAP<TEXT, TEXT>>)");
-        createIndex("CREATE INDEX ON %s(FULL(V))");
+        createIndexAsync("CREATE INDEX ON %s(FULL(V))");

Review Comment:
   nit: It doesn't affect correctness here, but would it be better to use `createIndex()` just to make sure that there's no lingering index build task active when the test completes? (i.e. If the default 2i changes later...)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org