You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/01 09:33:24 UTC

[GitHub] [flink] azagrebin commented on a change in pull request #11545: [FLINK-16742][runtime][dist] Extend and use BashJavaUtils to start JM JVM process and pass JVM memory args

azagrebin commented on a change in pull request #11545: [FLINK-16742][runtime][dist] Extend and use BashJavaUtils to start JM JVM process and pass JVM memory args
URL: https://github.com/apache/flink/pull/11545#discussion_r401481145
 
 

 ##########
 File path: flink-container/src/main/java/org/apache/flink/container/entrypoint/StandaloneJobClusterEntryPoint.java
 ##########
 @@ -116,6 +107,20 @@ public static void main(String[] args) {
 		ClusterEntrypoint.runClusterEntrypoint(entrypoint);
 	}
 
+	public static StandaloneJobClusterConfiguration getEntrypointClusterConfiguration(String[] args) {
+		final CommandLineParser<StandaloneJobClusterConfiguration> commandLineParser = new CommandLineParser<>(new StandaloneJobClusterConfigurationParserFactory());
 
 Review comment:
   Alright, thanks for the explanation. True, stopping of parsing because of an unknown option is a problem.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services