You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/09/03 07:23:40 UTC
Review Request 25285: Upgrade to latest in jetty 7.x series.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25285/
-----------------------------------------------------------
Review request for Aurora, David McLaughlin and Kevin Sweeney.
Bugs: AURORA-679
https://issues.apache.org/jira/browse/AURORA-679
Repository: aurora
Description
-------
Long story short: this change adds code, but enables us to remove code in a follow-up.
This change brings us to Jetty 7, which is the newest jetty that still uses servlet-api 2.5. Jetty 8/9 will require a larger yak shave since it pulls a dependency thread all the way to guice (servlet-api -> jersey-guice -> guice-servlet -> guice).
This is also a small step towards insulating ourselves from transitive dependencies pulled in from twitter commons.
[1] http://wiki.eclipse.org/Jetty/Starting/Porting_to_Jetty_7
Diffs
-----
build.gradle 66c8205c8354048c398623edf7ba75e721376b01
src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java de49a1c5497e32ee4db944412e5c87807c742d3c
src/main/java/org/apache/aurora/scheduler/http/RequestLogger.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/http/RequestLoggerTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/25285/diff/
Testing
-------
./gradlew build -Pq
Ran the scheduler in vagrant, verified index page works, request logging works, and all pages linked from the index page work.
Thanks,
Bill Farner
Re: Review Request 25285: Upgrade to latest in jetty 7.x series.
Posted by Joshua Cohen <jc...@twitter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25285/#review52186
-----------------------------------------------------------
Ship it!
Ship It!
- Joshua Cohen
On Sept. 3, 2014, 5:23 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25285/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2014, 5:23 a.m.)
>
>
> Review request for Aurora, David McLaughlin and Kevin Sweeney.
>
>
> Bugs: AURORA-679
> https://issues.apache.org/jira/browse/AURORA-679
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Long story short: this change adds code, but enables us to remove code in a follow-up.
>
> This change brings us to Jetty 7, which is the newest jetty that still uses servlet-api 2.5. Jetty 8/9 will require a larger yak shave since it pulls a dependency thread all the way to guice (servlet-api -> jersey-guice -> guice-servlet -> guice).
>
> This is also a small step towards insulating ourselves from transitive dependencies pulled in from twitter commons.
>
> [1] http://wiki.eclipse.org/Jetty/Starting/Porting_to_Jetty_7
>
>
> Diffs
> -----
>
> build.gradle 66c8205c8354048c398623edf7ba75e721376b01
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java de49a1c5497e32ee4db944412e5c87807c742d3c
> src/main/java/org/apache/aurora/scheduler/http/RequestLogger.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/RequestLoggerTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/25285/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
> Ran the scheduler in vagrant, verified index page works, request logging works, and all pages linked from the index page work.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 25285: Upgrade to latest in jetty 7.x series.
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25285/#review52203
-----------------------------------------------------------
Ship it!
Ship It!
- David McLaughlin
On Sept. 3, 2014, 5:23 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25285/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2014, 5:23 a.m.)
>
>
> Review request for Aurora, David McLaughlin and Kevin Sweeney.
>
>
> Bugs: AURORA-679
> https://issues.apache.org/jira/browse/AURORA-679
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Long story short: this change adds code, but enables us to remove code in a follow-up.
>
> This change brings us to Jetty 7, which is the newest jetty that still uses servlet-api 2.5. Jetty 8/9 will require a larger yak shave since it pulls a dependency thread all the way to guice (servlet-api -> jersey-guice -> guice-servlet -> guice).
>
> This is also a small step towards insulating ourselves from transitive dependencies pulled in from twitter commons.
>
> [1] http://wiki.eclipse.org/Jetty/Starting/Porting_to_Jetty_7
>
>
> Diffs
> -----
>
> build.gradle 66c8205c8354048c398623edf7ba75e721376b01
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java de49a1c5497e32ee4db944412e5c87807c742d3c
> src/main/java/org/apache/aurora/scheduler/http/RequestLogger.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/RequestLoggerTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/25285/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
> Ran the scheduler in vagrant, verified index page works, request logging works, and all pages linked from the index page work.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 25285: Upgrade to latest in jetty 7.x series.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25285/#review52190
-----------------------------------------------------------
Ship it!
src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java
<https://reviews.apache.org/r/25285/#comment90944>
typo
- Maxim Khutornenko
On Sept. 3, 2014, 5:23 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25285/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2014, 5:23 a.m.)
>
>
> Review request for Aurora, David McLaughlin and Kevin Sweeney.
>
>
> Bugs: AURORA-679
> https://issues.apache.org/jira/browse/AURORA-679
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Long story short: this change adds code, but enables us to remove code in a follow-up.
>
> This change brings us to Jetty 7, which is the newest jetty that still uses servlet-api 2.5. Jetty 8/9 will require a larger yak shave since it pulls a dependency thread all the way to guice (servlet-api -> jersey-guice -> guice-servlet -> guice).
>
> This is also a small step towards insulating ourselves from transitive dependencies pulled in from twitter commons.
>
> [1] http://wiki.eclipse.org/Jetty/Starting/Porting_to_Jetty_7
>
>
> Diffs
> -----
>
> build.gradle 66c8205c8354048c398623edf7ba75e721376b01
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java de49a1c5497e32ee4db944412e5c87807c742d3c
> src/main/java/org/apache/aurora/scheduler/http/RequestLogger.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/RequestLoggerTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/25285/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
> Ran the scheduler in vagrant, verified index page works, request logging works, and all pages linked from the index page work.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 25285: Upgrade to latest in jetty 7.x series.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25285/#review52221
-----------------------------------------------------------
Ship it!
This patch actually pulls in the bit of twitter.common.http that I would need to change to get ShiroWebModule wired in, so big +1 from me
- Kevin Sweeney
On Sept. 2, 2014, 10:23 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25285/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2014, 10:23 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Kevin Sweeney.
>
>
> Bugs: AURORA-679
> https://issues.apache.org/jira/browse/AURORA-679
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Long story short: this change adds code, but enables us to remove code in a follow-up.
>
> This change brings us to Jetty 7, which is the newest jetty that still uses servlet-api 2.5. Jetty 8/9 will require a larger yak shave since it pulls a dependency thread all the way to guice (servlet-api -> jersey-guice -> guice-servlet -> guice).
>
> This is also a small step towards insulating ourselves from transitive dependencies pulled in from twitter commons.
>
> [1] http://wiki.eclipse.org/Jetty/Starting/Porting_to_Jetty_7
>
>
> Diffs
> -----
>
> build.gradle 66c8205c8354048c398623edf7ba75e721376b01
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java de49a1c5497e32ee4db944412e5c87807c742d3c
> src/main/java/org/apache/aurora/scheduler/http/RequestLogger.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/RequestLoggerTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/25285/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
> Ran the scheduler in vagrant, verified index page works, request logging works, and all pages linked from the index page work.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 25285: Upgrade to latest in jetty 7.x series.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25285/
-----------------------------------------------------------
(Updated Sept. 4, 2014, 6:37 p.m.)
Review request for Aurora, David McLaughlin and Kevin Sweeney.
Changes
-------
Realized that static assets were no longer showing up on the index page. Latest diff fixes that.
Bugs: AURORA-679
https://issues.apache.org/jira/browse/AURORA-679
Repository: aurora
Description
-------
Long story short: this change adds code, but enables us to remove code in a follow-up.
This change brings us to Jetty 7, which is the newest jetty that still uses servlet-api 2.5. Jetty 8/9 will require a larger yak shave since it pulls a dependency thread all the way to guice (servlet-api -> jersey-guice -> guice-servlet -> guice).
This is also a small step towards insulating ourselves from transitive dependencies pulled in from twitter commons.
[1] http://wiki.eclipse.org/Jetty/Starting/Porting_to_Jetty_7
Diffs (updated)
-----
build.gradle 494c54421f716412d20d4591c2d39e24f647c071
src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java de49a1c5497e32ee4db944412e5c87807c742d3c
src/main/java/org/apache/aurora/scheduler/http/RequestLogger.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/http/RequestLoggerTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/25285/diff/
Testing
-------
./gradlew build -Pq
Ran the scheduler in vagrant, verified index page works, request logging works, and all pages linked from the index page work.
Thanks,
Bill Farner
Re: Review Request 25285: Upgrade to latest in jetty 7.x series.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25285/
-----------------------------------------------------------
(Updated Sept. 4, 2014, 5:48 p.m.)
Review request for Aurora, David McLaughlin and Kevin Sweeney.
Bugs: AURORA-679
https://issues.apache.org/jira/browse/AURORA-679
Repository: aurora
Description
-------
Long story short: this change adds code, but enables us to remove code in a follow-up.
This change brings us to Jetty 7, which is the newest jetty that still uses servlet-api 2.5. Jetty 8/9 will require a larger yak shave since it pulls a dependency thread all the way to guice (servlet-api -> jersey-guice -> guice-servlet -> guice).
This is also a small step towards insulating ourselves from transitive dependencies pulled in from twitter commons.
[1] http://wiki.eclipse.org/Jetty/Starting/Porting_to_Jetty_7
Diffs (updated)
-----
build.gradle 494c54421f716412d20d4591c2d39e24f647c071
src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java de49a1c5497e32ee4db944412e5c87807c742d3c
src/main/java/org/apache/aurora/scheduler/http/RequestLogger.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/http/RequestLoggerTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/25285/diff/
Testing
-------
./gradlew build -Pq
Ran the scheduler in vagrant, verified index page works, request logging works, and all pages linked from the index page work.
Thanks,
Bill Farner