You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/05/18 05:22:54 UTC

[GitHub] [camel-k] tadayosi commented on pull request #3279: chore(cmd/trait): refactor cmd & trait packages

tadayosi commented on PR #3279:
URL: https://github.com/apache/camel-k/pull/3279#issuecomment-1129579155

   @squakez Actually the tests in `trait_types_test.go` are for testing the methods `e.collectConfigurationValues()` and `e.collectConfigurationPairs()`, which operate on the deprecated `Configuration` fields. So I don't think there is any point in having those tests if we rewrite them to use the corresponding traits.
   
   I think the best timing to remove those tests is when we finally remove the deprecated fields and related coded.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org