[jira] Updated: (OFBIZ-1952) delegator.removeByAnd(entityName) fails with sql syntax error

["Marco Ruocco (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Ruocco updated OFBIZ-1952:
--------------------------------

    Attachment: GenericDAO.patch

Hi,

in this attachment I propose my solution to that issue. 
I have worked on OFBiz revision 724649 on MS Windows XP System

> delegator.removeByAnd(entityName) fails with sql syntax error
> -------------------------------------------------------------
>
>                 Key: OFBIZ-1952
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1952
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adam Heath
>            Priority: Minor
>         Attachments: GenericDAO.patch
>
>
> delegator.removeByAnd(entityName) calls delegator.removeByAnd(entityName, (Map) null).  This eventually calls GenericDAO.deleteByCondition, with the condition being an EntityFieldMap with an emptyMap.  In this case, the EntityCondition.makeWhereString returns an empty string, so doing:
> sql += "WHERE" + condition.makeWhereString(...)
> fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.