[jira] [Resolved] (WICKET-5450) Double escaping when using EnumChoiceRenderer and DropDownChoice

["Martin Grigorov (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-5450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov resolved WICKET-5450.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 7.0.0
                   6.13.0

Removed the escaping.
The #postprocess() method is preserved, so the application can override it and revert to the old behavior.

> Double escaping when using EnumChoiceRenderer and DropDownChoice
> ----------------------------------------------------------------
>
>                 Key: WICKET-5450
>                 URL: https://issues.apache.org/jira/browse/WICKET-5450
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 6.12.0
>            Reporter: Guillaume Smet
>            Assignee: Martin Grigorov
>             Fix For: 6.13.0, 7.0.0
>
>
> From my post on the dev@ list:
> Currently, EnumChoiceRenderer escapes the value via the postprocess method.
> It seems to be redundant with the fact that DropDownChoice already
> escapes the value by default (in AbstractChoice).
> Typically, in a default setup, if you use EnumChoiceRenderer and
> DropDownChoice together, your value is escaped twice which leads to a
> double escaped value.
> Should I open a JIRA so that we remove the escaping of EnumChoiceRenderer?
> References:
> https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/markup/html/form/EnumChoiceRenderer.java#L111
> https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/markup/html/form/AbstractChoice.java#L402



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)