You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by "Gavin (JIRA)" <ji...@apache.org> on 2006/04/23 15:14:05 UTC

[jira] Updated: (FOR-851) upgrade Voice plugin to use current Dispatcher

     [ http://issues.apache.org/jira/browse/FOR-851?page=all ]

Gavin updated FOR-851:
----------------------

    Attachment: voice-plugin.diff

Well, I tried a different way of making the diff file, so all changes are in the one file rather than having a diff file for each file I changed/added/deleted. Let me know if this works and if so should be easier to apply.

The diff attached upgraded the voice plugin to dispatcher.

Checklist : Passes Ant Test, Passes Forrest Site, Passes Forrest Run and works fine in localhost. Plugin Tested in Opera and seems to work fine.

> upgrade Voice plugin to use current Dispatcher
> ----------------------------------------------
>
>          Key: FOR-851
>          URL: http://issues.apache.org/jira/browse/FOR-851
>      Project: Forrest
>         Type: Bug

>   Components: Dispatcher (aka views), Plugin: output.voice
>     Versions: 0.8-dev
>     Reporter: David Crossley
>      Fix For: 0.8-dev
>  Attachments: voice-plugin.diff
>
> The voice plugin is still using the old experimental Structurer plugins.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Re: [jira] Updated: (FOR-851) upgrade Voice plugin to use current Dispatcher

Posted by Thorsten Scherler <th...@apache.org>.
El dom, 23-04-2006 a las 13:14 +0000, Gavin (JIRA) escribió:
>      [ http://issues.apache.org/jira/browse/FOR-851?page=all ]
> 
> Gavin updated FOR-851:
> ----------------------
> 
>     Attachment: voice-plugin.diff
> 
> Well, I tried a different way of making the diff file, so all changes are in the one file rather than having a diff file for each file I changed/added/deleted. Let me know if this works and if so should be easier to apply.

That is the way to go. 

Heaps easier to follow. 

BTW this patches are a good training how commits have to look like. ;)

> 
> The diff attached upgraded the voice plugin to dispatcher.
> 
> Checklist : Passes Ant Test, Passes Forrest Site, Passes Forrest Run and works fine in localhost. Plugin Tested in Opera and seems to work fine.
> 

Nice. 

Thx Gavin.

salu2
-- 
thorsten

"Together we stand, divided we fall!" 
Hey you (Pink Floyd)


Re: [jira] Updated: (FOR-851) upgrade Voice plugin to use current Dispatcher

Posted by Ross Gardler <rg...@apache.org>.
Gav.... wrote:
> Hope I'm not being a PITA here but if someone could have a go at
> Applying this I would be grateful. 

Since this is dispatcher related we need someone with dispatcher 
knowledge to apply this. Personally, I'm still working in dispatcher 2 
for various (non technical) reasons.

Ross

RE: [jira] Updated: (FOR-851) upgrade Voice plugin to use current Dispatcher

Posted by "Gav...." <br...@brightontown.com.au>.
Hope I'm not being a PITA here but if someone could have a go at
Applying this I would be grateful. Not for the fact that it closes
A roadmap 0.8 issue, but that David explained to me what is
Considered a more Committer friendly way of applying the svn diff
To the patch.

So, before I can patch more this way, I just want to know if it
Worked ok or if I have more improvements to do.

Gav...

> -----Original Message-----
> From: Gavin (JIRA) [mailto:jira@apache.org]
> Sent: Sunday, 23 April 2006 9:14 PM
> To: dev@forrest.apache.org
> Subject: [jira] Updated: (FOR-851) upgrade Voice plugin to use current
> Dispatcher
> 
>      [ http://issues.apache.org/jira/browse/FOR-851?page=all ]
> 
> Gavin updated FOR-851:
> ----------------------
> 
>     Attachment: voice-plugin.diff
> 
> Well, I tried a different way of making the diff file, so all changes are
> in the one file rather than having a diff file for each file I
> changed/added/deleted. Let me know if this works and if so should be
> easier to apply.
> 
> The diff attached upgraded the voice plugin to dispatcher.
> 
> Checklist : Passes Ant Test, Passes Forrest Site, Passes Forrest Run and
> works fine in localhost. Plugin Tested in Opera and seems to work fine.
> 
> > upgrade Voice plugin to use current Dispatcher
> > ----------------------------------------------
> >
> >          Key: FOR-851
> >          URL: http://issues.apache.org/jira/browse/FOR-851
> >      Project: Forrest
> >         Type: Bug
> 
> >   Components: Dispatcher (aka views), Plugin: output.voice
> >     Versions: 0.8-dev
> >     Reporter: David Crossley
> >      Fix For: 0.8-dev
> >  Attachments: voice-plugin.diff
> >
> > The voice plugin is still using the old experimental Structurer plugins.
> 
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
>    http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see:
>    http://www.atlassian.com/software/jira
> 
> 
> 
> --
> No virus found in this incoming message.
> Checked by AVG Free Edition.
> Version: 7.1.385 / Virus Database: 268.4.5/322 - Release Date: 22/04/2006