[GitHub] [hive] kasakrisz commented on a diff in pull request #3823: HIVE-26578: Enable Iceberg storage format for materialized views

[GitBox <gi...@apache.org>]

kasakrisz commented on code in PR #3823:
URL: https://github.com/apache/hive/pull/3823#discussion_r1042367508


##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/create/CreateMaterializedViewDesc.java:
##########
@@ -237,11 +237,17 @@ public void setTblProps(Map<String, String> tblProps) {
     this.tblProps = tblProps;
   }
 
-  @Explain(displayName = "table properties")
   public Map<String, String> getTblProps() {
     return tblProps;
   }
 
+  @Explain(displayName = "table properties")
+  public Map<String, String> getTblPropsExplain() { // only for displaying plan
+    return PlanUtils.getPropertiesForExplain(tblProps,
+            hive_metastoreConstants.TABLE_IS_CTAS,

Review Comment:
   Renamed the constant but kept the value since it would break compatibility.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org