You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Shwetha GS <ss...@hortonworks.com> on 2016/01/05 07:53:13 UTC

Review Request 41918: FALCON-1721 Checkstyle module should have falcon-main as parent

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41918/
-----------------------------------------------------------

Review request for Falcon.


Bugs: FALCON-1721
    https://issues.apache.org/jira/browse/FALCON-1721


Repository: falcon-git


Description
-------

Currently, checkstyle module is independent module and doesn't have a parent pom. All the modules should extend apache pom for deploying artifacts in apache mvn repository. Checkstyle related files can be in falcon/src and an extra module for checkstyle is not required


Diffs
-----

  checkstyle/pom.xml 3e2f2fd 
  checkstyle/src/main/resources/falcon/checkstyle-java-header.txt 5d5f1e3 
  checkstyle/src/main/resources/falcon/checkstyle-noframes.xsl 6308ef8 
  checkstyle/src/main/resources/falcon/checkstyle-suppressions.xml 3b75811 
  checkstyle/src/main/resources/falcon/checkstyle.xml 292a0a3 
  checkstyle/src/main/resources/falcon/findbugs-exclude.xml e1a5a2e 
  pom.xml 3a4d5dd 

Diff: https://reviews.apache.org/r/41918/diff/


Testing
-------

Build succeeded with 'mvn clean install -Ptest-patch,hadoop-2'


Thanks,

Shwetha GS

Re: Review Request 41918: FALCON-1721 Checkstyle module should have falcon-main as parent

Posted by Balu Vellanki <bv...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41918/#review112900
-----------------------------------------------------------

Ship it!


Ship It!

- Balu Vellanki


On Jan. 5, 2016, 6:53 a.m., Shwetha GS wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41918/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 6:53 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1721
>     https://issues.apache.org/jira/browse/FALCON-1721
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Currently, checkstyle module is independent module and doesn't have a parent pom. All the modules should extend apache pom for deploying artifacts in apache mvn repository. Checkstyle related files can be in falcon/src and an extra module for checkstyle is not required
> 
> 
> Diffs
> -----
> 
>   checkstyle/pom.xml 3e2f2fd 
>   checkstyle/src/main/resources/falcon/checkstyle-java-header.txt 5d5f1e3 
>   checkstyle/src/main/resources/falcon/checkstyle-noframes.xsl 6308ef8 
>   checkstyle/src/main/resources/falcon/checkstyle-suppressions.xml 3b75811 
>   checkstyle/src/main/resources/falcon/checkstyle.xml 292a0a3 
>   checkstyle/src/main/resources/falcon/findbugs-exclude.xml e1a5a2e 
>   pom.xml 3a4d5dd 
> 
> Diff: https://reviews.apache.org/r/41918/diff/
> 
> 
> Testing
> -------
> 
> Build succeeded with 'mvn clean install -Ptest-patch,hadoop-2'
> 
> 
> Thanks,
> 
> Shwetha GS
> 
>