You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2018/10/05 23:20:16 UTC
[kudu-CR] [mac] Add support for XCode 10
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11602
Change subject: [mac] Add support for XCode 10
......................................................................
[mac] Add support for XCode 10
Change-Id: I442a1cd4605858b0800fc7d7686817936efd155e
---
M cmake_modules/CompilerInfo.cmake
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/11602/1
--
To view, visit http://gerrit.cloudera.org:8080/11602
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I442a1cd4605858b0800fc7d7686817936efd155e
Gerrit-Change-Number: 11602
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
[kudu-CR] [mac] Add support for XCode 10
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11602 )
Change subject: [mac] Add support for XCode 10
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11602/1/cmake_modules/CompilerInfo.cmake
File cmake_modules/CompilerInfo.cmake:
http://gerrit.cloudera.org:8080/#/c/11602/1/cmake_modules/CompilerInfo.cmake@60
PS1, Line 60: # TODO(wdberkeley): 4.1.0svn is also just a guess, for the same reasons, and
> I think it's more likely to be 5.x or 6.x, but who knows ¯\_(?)_/¯
It seems Xcode 10 uses LLVM very close to 6.0.0 according to this:
https://gist.github.com/yamaya/2924292#gistcomment-2683289
--
To view, visit http://gerrit.cloudera.org:8080/11602
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I442a1cd4605858b0800fc7d7686817936efd155e
Gerrit-Change-Number: 11602
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Sat, 06 Oct 2018 00:48:41 +0000
Gerrit-HasComments: Yes
[kudu-CR] [mac] Add support for XCode 10
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11602 )
Change subject: [mac] Add support for XCode 10
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11602
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I442a1cd4605858b0800fc7d7686817936efd155e
Gerrit-Change-Number: 11602
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Sun, 07 Oct 2018 04:38:04 +0000
Gerrit-HasComments: No
[kudu-CR] [mac] Add support for XCode 10
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11602
to look at the new patch set (#2).
Change subject: [mac] Add support for XCode 10
......................................................................
[mac] Add support for XCode 10
Change-Id: I442a1cd4605858b0800fc7d7686817936efd155e
---
M cmake_modules/CompilerInfo.cmake
1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/11602/2
--
To view, visit http://gerrit.cloudera.org:8080/11602
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I442a1cd4605858b0800fc7d7686817936efd155e
Gerrit-Change-Number: 11602
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [mac] Add support for XCode 10
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11602 )
Change subject: [mac] Add support for XCode 10
......................................................................
Patch Set 3: Verified+1 Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11602
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I442a1cd4605858b0800fc7d7686817936efd155e
Gerrit-Change-Number: 11602
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 08 Oct 2018 15:04:43 +0000
Gerrit-HasComments: No
[kudu-CR] [mac] Add support for XCode 10
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11602 )
Change subject: [mac] Add support for XCode 10
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11602/1/cmake_modules/CompilerInfo.cmake
File cmake_modules/CompilerInfo.cmake:
http://gerrit.cloudera.org:8080/#/c/11602/1/cmake_modules/CompilerInfo.cmake@60
PS1, Line 60: # TODO(wdberkeley): 6.0.0svn is also just a guess, for the same reason, and
> Actually, next comment (the prior one was about Xcode 9.1.0): https://gist.
Done
--
To view, visit http://gerrit.cloudera.org:8080/11602
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I442a1cd4605858b0800fc7d7686817936efd155e
Gerrit-Change-Number: 11602
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Sat, 06 Oct 2018 03:16:12 +0000
Gerrit-HasComments: Yes
[kudu-CR] [mac] Add support for XCode 10
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11602
to look at the new patch set (#3).
Change subject: [mac] Add support for XCode 10
......................................................................
[mac] Add support for XCode 10
Change-Id: I442a1cd4605858b0800fc7d7686817936efd155e
---
M cmake_modules/CompilerInfo.cmake
1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/11602/3
--
To view, visit http://gerrit.cloudera.org:8080/11602
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I442a1cd4605858b0800fc7d7686817936efd155e
Gerrit-Change-Number: 11602
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [mac] Add support for XCode 10
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11602 )
Change subject: [mac] Add support for XCode 10
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11602/1/cmake_modules/CompilerInfo.cmake
File cmake_modules/CompilerInfo.cmake:
http://gerrit.cloudera.org:8080/#/c/11602/1/cmake_modules/CompilerInfo.cmake@60
PS1, Line 60: # TODO(wdberkeley): 4.1.0svn is also just a guess, for the same reasons, and
I think it's more likely to be 5.x or 6.x, but who knows ¯\_(?)_/¯
--
To view, visit http://gerrit.cloudera.org:8080/11602
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I442a1cd4605858b0800fc7d7686817936efd155e
Gerrit-Change-Number: 11602
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Sat, 06 Oct 2018 00:12:49 +0000
Gerrit-HasComments: Yes
[kudu-CR] [mac] Add support for XCode 10
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11602 )
Change subject: [mac] Add support for XCode 10
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11602/1/cmake_modules/CompilerInfo.cmake
File cmake_modules/CompilerInfo.cmake:
http://gerrit.cloudera.org:8080/#/c/11602/1/cmake_modules/CompilerInfo.cmake@60
PS1, Line 60: # TODO(wdberkeley): 4.1.0svn is also just a guess, for the same reasons, and
> It seems Xcode 10 uses LLVM very close to 6.0.0 according to this:
Actually, next comment (the prior one was about Xcode 9.1.0): https://gist.github.com/yamaya/2924292#gistcomment-2702452
--
To view, visit http://gerrit.cloudera.org:8080/11602
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I442a1cd4605858b0800fc7d7686817936efd155e
Gerrit-Change-Number: 11602
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Sat, 06 Oct 2018 00:52:02 +0000
Gerrit-HasComments: Yes
[kudu-CR] [mac] Add support for XCode 10
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11602 )
Change subject: [mac] Add support for XCode 10
......................................................................
[mac] Add support for XCode 10
Change-Id: I442a1cd4605858b0800fc7d7686817936efd155e
Reviewed-on: http://gerrit.cloudera.org:8080/11602
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Attila Bukor <ab...@apache.org>
Tested-by: Attila Bukor <ab...@apache.org>
---
M cmake_modules/CompilerInfo.cmake
1 file changed, 10 insertions(+), 0 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
Attila Bukor: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/11602
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I442a1cd4605858b0800fc7d7686817936efd155e
Gerrit-Change-Number: 11602
Gerrit-PatchSet: 4
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>