You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@rocketmq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/03/09 04:38:37 UTC
[jira] [Commented] (ROCKETMQ-135) Broker cannot be properly
finalized on failure to load a storage plugin
[ https://issues.apache.org/jira/browse/ROCKETMQ-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15902468#comment-15902468 ]
ASF GitHub Bot commented on ROCKETMQ-135:
-----------------------------------------
GitHub user shroman opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/73
[ROCKETMQ-135] Broker cannot be properly finalized on failure to load…
… a storage plugin.
JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-135
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shroman/incubator-rocketmq ROCKETMQ-135
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/73.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #73
----
commit f3ce58b74d164860abdb191c9816c03edd4a9278
Author: shtykh_roman <rs...@yahoo.com>
Date: 2017-03-09T04:36:21Z
[ROCKETMQ-135] Broker cannot be properly finalized on failure to load a storage plugin.
JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-135
----
> Broker cannot be properly finalized on failure to load a storage plugin
> -----------------------------------------------------------------------
>
> Key: ROCKETMQ-135
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-135
> Project: Apache RocketMQ
> Issue Type: Bug
> Components: rocketmq-broker
> Affects Versions: 4.0.0-incubating
> Reporter: Roman Shtykh
> Assignee: Roman Shtykh
>
> When a storage plugin fails ( {{org.apache.rocketmq.broker.plugin.MessageStoreFactory#build}} ), it terminates the broker without proper finalization.
> This is because {{RuntimeException}} is thrown by the above-mentioned method and it is never properly handled.
> I propose creating a {{BrokerException}}, throw it and properly handle.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)