You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/05/24 21:19:59 UTC
[Impala-ASF-CR] IMPALA-5359: [DOCS] Document SORT BY syntax for CREATE TABLE and ALTER TABLE
John Russell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6981
Change subject: IMPALA-5359: [DOCS] Document SORT BY syntax for CREATE TABLE and ALTER TABLE
......................................................................
IMPALA-5359: [DOCS] Document SORT BY syntax for CREATE TABLE and ALTER TABLE
Review part 1: Just tackling the CREATE TABLE syntax and examples for
now. Will have separate gerrits for ALTER TABLE and more far-flung
places to mention this feature (New Features, Performance
Considerations, Parquet File Format).
Change-Id: Icd571cd8840368edb327d16d27192458838ef234
---
M docs/topics/impala_create_table.xml
1 file changed, 74 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/81/6981/1
--
To view, visit http://gerrit.cloudera.org:8080/6981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icd571cd8840368edb327d16d27192458838ef234
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] IMPALA-5359: [DOCS] Document SORT BY syntax for CREATE TABLE and ALTER TABLE
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5359: [DOCS] Document SORT BY syntax for CREATE TABLE and ALTER TABLE
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd571cd8840368edb327d16d27192458838ef234
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5359: [DOCS] Document SORT BY syntax for CREATE TABLE and ALTER TABLE
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5359: [DOCS] Document SORT BY syntax for CREATE TABLE and ALTER TABLE
......................................................................
Patch Set 2:
Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/124/
--
To view, visit http://gerrit.cloudera.org:8080/6981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd571cd8840368edb327d16d27192458838ef234
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5359: [DOCS] Document SORT BY syntax for CREATE TABLE and ALTER TABLE
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5359: [DOCS] Document SORT BY syntax for CREATE TABLE and ALTER TABLE
......................................................................
IMPALA-5359: [DOCS] Document SORT BY syntax for CREATE TABLE and ALTER TABLE
Review part 1: Just tackling the CREATE TABLE syntax and examples for
now. Will have separate gerrits for ALTER TABLE and more far-flung
places to mention this feature (New Features, Performance
Considerations, Parquet File Format).
Change-Id: Icd571cd8840368edb327d16d27192458838ef234
Reviewed-on: http://gerrit.cloudera.org:8080/6981
Reviewed-by: Lars Volker <lv...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/topics/impala_create_table.xml
1 file changed, 80 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Lars Volker: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/6981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icd571cd8840368edb327d16d27192458838ef234
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-5359: [DOCS] Document SORT BY syntax for CREATE TABLE and ALTER TABLE
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: IMPALA-5359: [DOCS] Document SORT BY syntax for CREATE TABLE and ALTER TABLE
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd571cd8840368edb327d16d27192458838ef234
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5359: [DOCS] Document SORT BY syntax for CREATE TABLE and ALTER TABLE
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: IMPALA-5359: [DOCS] Document SORT BY syntax for CREATE TABLE and ALTER TABLE
......................................................................
Patch Set 1:
(5 comments)
Thank you for documenting this. Please see my inline comments. Let me know if you'd like to discuss them in person.
http://gerrit.cloudera.org:8080/#/c/6981/1/docs/topics/impala_create_table.xml
File docs/topics/impala_create_table.xml:
Line 388: <codeph>CREATE TABLE AS SELECT</codeph> operation. Creating data files that are
I think it's important to understand that the source table property does not affect the target table. CREATE TABLE TARGET AS SELECT * FROM SOURCE; with SOURCE having SORT BY() columns will not copy them over to TARGET.
Line 389: sorted is most useful for Parquet tables, where the metadata includes the minimum and
Here it should be clear that the information is stored in the file metadata inside each Parquet file, and not in our own metadata store.
Line 390: maximum values for each column in each data file. Grouping data values together
Technically, statistics are stored per RowGroup. Impala only writes 1 rowgroup per file, but that's a self imposed limitation.
Line 400: evident with Parquet tables.
We could mention here, that other file formats don't have statistics inside the file metadata.
Line 412: tools that creat HDFS files, Impala does not guarantee or rely on the data being
typo
--
To view, visit http://gerrit.cloudera.org:8080/6981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd571cd8840368edb327d16d27192458838ef234
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5359: [DOCS] Document SORT BY syntax for CREATE TABLE and ALTER TABLE
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-5359: [DOCS] Document SORT BY syntax for CREATE TABLE and ALTER TABLE
......................................................................
Patch Set 1:
(5 comments)
Addressed all the comments from Lars.
http://gerrit.cloudera.org:8080/#/c/6981/1/docs/topics/impala_create_table.xml
File docs/topics/impala_create_table.xml:
Line 388: <codeph>CREATE TABLE AS SELECT</codeph> operation. Creating data files that are
> I think it's important to understand that the source table property does no
OK. I will mention that in a subsequent paragraph talking about cases where SORT BY does or doesn't apply.
Line 389: sorted is most useful for Parquet tables, where the metadata includes the minimum and
> Here it should be clear that the information is stored in the file metadata
Done
Line 390: maximum values for each column in each data file. Grouping data values together
> Technically, statistics are stored per RowGroup. Impala only writes 1 rowgr
Done
Line 400: evident with Parquet tables.
> We could mention here, that other file formats don't have statistics inside
Done
Line 412: tools that creat HDFS files, Impala does not guarantee or rely on the data being
> typo
Done
--
To view, visit http://gerrit.cloudera.org:8080/6981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd571cd8840368edb327d16d27192458838ef234
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5359: [DOCS] Document SORT BY syntax for CREATE TABLE and ALTER TABLE
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#2).
Change subject: IMPALA-5359: [DOCS] Document SORT BY syntax for CREATE TABLE and ALTER TABLE
......................................................................
IMPALA-5359: [DOCS] Document SORT BY syntax for CREATE TABLE and ALTER TABLE
Review part 1: Just tackling the CREATE TABLE syntax and examples for
now. Will have separate gerrits for ALTER TABLE and more far-flung
places to mention this feature (New Features, Performance
Considerations, Parquet File Format).
Change-Id: Icd571cd8840368edb327d16d27192458838ef234
---
M docs/topics/impala_create_table.xml
1 file changed, 80 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/81/6981/2
--
To view, visit http://gerrit.cloudera.org:8080/6981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icd571cd8840368edb327d16d27192458838ef234
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>