[jira] [Commented] (MAPREDUCE-5531) Binary and source incompatibility in mapreduce.TaskID and mapreduce.TaskAttemptID between branch-1 and branch-2

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-5531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776561#comment-13776561 ] 

Hadoop QA commented on MAPREDUCE-5531:
--------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12604843/MAPREDUCE-5531.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4035//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4035//console

This message is automatically generated.
                
> Binary and source incompatibility in mapreduce.TaskID and mapreduce.TaskAttemptID between branch-1 and branch-2
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5531
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5531
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv1, mrv2
>    Affects Versions: 2.1.1-beta
>            Reporter: Robert Kanter
>            Assignee: Robert Kanter
>            Priority: Blocker
>         Attachments: MAPREDUCE-5531.patch
>
>
> {{mapreduce.TaskID}} in branch-1 has these two constructors:
> {code:java}
> public TaskID(JobID jobId, boolean isMap, int id)
> public TaskID(String jtIdentifier, int jobId, boolean isMap, int id)
> {code}
> In branch-2, {{mapreduce.TaskID}} no longer has either of the above two constructors.  
> Also, {{mapreduce.TaskAttemptID}} in branch-1 has this constructor:
> {code:java}
> public TaskAttemptID(String jtIdentifier, int jobId, boolean isMap, int taskId, int id)
> {code}
> In branch-2, {{mapreduce.TaskAttemptID}} no longer his this constructor.
> It looks like these constructors were probably removed because the {{boolean isMap}} was replaced by an enum, {{TaskType}}.
> This means that any code that tries to use any of those constructors will not be binary or source compatible (in fact, the missing {{TaskAttemptID}} constructor calls one of the missing {{TaskID}} constructors).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira