[jira] [Commented] (THRIFT-3238) Fix TNamedPipeServer can be interrupted by faulty client

["Mario Emmenlauer (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-3238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17088762#comment-17088762 ] 

Mario Emmenlauer commented on THRIFT-3238:
------------------------------------------

What is required to proceed with this? From what I could see, [~tewang] implemented the changes requested by [~ben.craig] and at least the first review by [~ben.craig] seems to support this route. 

And generally the fix seems quite relevant for the robustness of the pipes. Or am I on the wrong track?

> Fix TNamedPipeServer can be interrupted by faulty client
> --------------------------------------------------------
>
>                 Key: THRIFT-3238
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3238
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.9.2
>         Environment: Windows
>            Reporter: Paweł Janicki
>            Priority: Major
>         Attachments: 0001-Fix-TNamedPipeServer-can-be-interrupted-by-faulty-cl.patch, 0002-THRIFT-3238.-cpp-Fix-TNamedPipeServer-can-be-interru.patch
>
>
> A faulty or hostile client can cause TNamedPipeServer to be interrupted and return from serve(). The client that causes such effect just needs to open and immediately close TPipe transport.
> Caused by not handling some NamedPipe error codes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)