You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by kiszk <gi...@git.apache.org> on 2017/11/03 03:23:43 UTC

[GitHub] spark pull request #19650: [SPARK-22254][core] Fix the arrayMax in BufferHol...

GitHub user kiszk opened a pull request:

    https://github.com/apache/spark/pull/19650

    [SPARK-22254][core] Fix the arrayMax in BufferHolder

    ## What changes were proposed in this pull request?
    
    This PR replaces the old the maximum array size (`Int.MaxValue`) with the new one (`ByteArrayMethods.MAX_ROUNDED_ARRAY_LENGTH`).
    This PR also refactor the code to calculate the new array size to easily understand why we have to use `newSize - 2` for allocating a new array.
    
    ## How was this patch tested?
    
    Used the existing test

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kiszk/spark SPARK-22254

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/19650.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19650
    
----
commit 0a536fb0dbaa9e1e929610ecc15ac416253fd823
Author: Kazuaki Ishizaki <is...@jp.ibm.com>
Date:   2017-11-03T03:14:00Z

    initial commit

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19650: [SPARK-22254][core] Fix the arrayMax in BufferHolder

Posted by kiszk <gi...@git.apache.org>.
Github user kiszk commented on the issue:

    https://github.com/apache/spark/pull/19650
  
    @srowen @gatorsmile could you please review this?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #19650: [SPARK-22254][core] Fix the arrayMax in BufferHol...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/19650


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19650: [SPARK-22254][core] Fix the arrayMax in BufferHolder

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19650
  
    **[Test build #83376 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83376/testReport)** for PR 19650 at commit [`0a536fb`](https://github.com/apache/spark/commit/0a536fb0dbaa9e1e929610ecc15ac416253fd823).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19650: [SPARK-22254][core] Fix the arrayMax in BufferHolder

Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/19650
  
    Thanks! Merged to master.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19650: [SPARK-22254][core] Fix the arrayMax in BufferHolder

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19650
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83376/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19650: [SPARK-22254][core] Fix the arrayMax in BufferHolder

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19650
  
    **[Test build #83376 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83376/testReport)** for PR 19650 at commit [`0a536fb`](https://github.com/apache/spark/commit/0a536fb0dbaa9e1e929610ecc15ac416253fd823).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19650: [SPARK-22254][core] Fix the arrayMax in BufferHolder

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19650
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org