You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by sp...@apache.org on 2015/06/01 23:16:12 UTC
[3/4] incubator-tinkerpop git commit: Finalize some classes in
gremlin-driver.
Finalize some classes in gremlin-driver.
Project: http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/commit/f6b0ec6c
Tree: http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/tree/f6b0ec6c
Diff: http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/diff/f6b0ec6c
Branch: refs/heads/master
Commit: f6b0ec6cb06f75b8883fe2e335022a43083736c2
Parents: cd3d927
Author: Stephen Mallette <sp...@genoprime.com>
Authored: Mon Jun 1 15:54:45 2015 -0400
Committer: Stephen Mallette <sp...@genoprime.com>
Committed: Mon Jun 1 17:15:51 2015 -0400
----------------------------------------------------------------------
.../java/org/apache/tinkerpop/gremlin/driver/Channelizer.java | 4 ++--
.../main/java/org/apache/tinkerpop/gremlin/driver/Client.java | 4 ++--
.../main/java/org/apache/tinkerpop/gremlin/driver/Cluster.java | 2 +-
.../java/org/apache/tinkerpop/gremlin/driver/Connection.java | 2 +-
.../java/org/apache/tinkerpop/gremlin/driver/ConnectionPool.java | 2 +-
.../main/java/org/apache/tinkerpop/gremlin/driver/Handler.java | 2 +-
.../src/main/java/org/apache/tinkerpop/gremlin/driver/Host.java | 2 +-
.../main/java/org/apache/tinkerpop/gremlin/driver/Result.java | 2 +-
.../java/org/apache/tinkerpop/gremlin/driver/ResultQueue.java | 2 +-
.../main/java/org/apache/tinkerpop/gremlin/driver/ResultSet.java | 2 +-
10 files changed, 12 insertions(+), 12 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/blob/f6b0ec6c/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Channelizer.java
----------------------------------------------------------------------
diff --git a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Channelizer.java b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Channelizer.java
index 572a537..eaa8eff 100644
--- a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Channelizer.java
+++ b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Channelizer.java
@@ -113,7 +113,7 @@ public interface Channelizer extends ChannelHandler {
/**
* WebSocket {@link Channelizer} implementation.
*/
- class WebSocketChannelizer extends AbstractChannelizer {
+ final class WebSocketChannelizer extends AbstractChannelizer {
private WebSocketClientHandler handler;
private WebSocketGremlinRequestEncoder webSocketGremlinRequestEncoder;
@@ -166,7 +166,7 @@ public interface Channelizer extends ChannelHandler {
/**
* NIO {@link Channelizer} implementation.
*/
- class NioChannelizer extends AbstractChannelizer {
+ final class NioChannelizer extends AbstractChannelizer {
private NioGremlinRequestEncoder nioGremlinRequestEncoder;
@Override
http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/blob/f6b0ec6c/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Client.java
----------------------------------------------------------------------
diff --git a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Client.java b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Client.java
index 9527294..1111f67 100644
--- a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Client.java
+++ b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Client.java
@@ -181,7 +181,7 @@ public abstract class Client {
* given a {@link LoadBalancingStrategy}. Transactions are automatically committed
* (or rolled-back on error) after each request.
*/
- public static class ClusteredClient extends Client {
+ public final static class ClusteredClient extends Client {
private ConcurrentMap<Host, ConnectionPool> hostConnectionPools = new ConcurrentHashMap<>();
@@ -238,7 +238,7 @@ public abstract class Client {
* server, where each request is bound to the same thread with the same set of bindings across requests.
* Transaction are not automatically committed. It is up the client to issue commit/rollback commands.
*/
- public static class SessionedClient extends Client {
+ public final static class SessionedClient extends Client {
private final String sessionId;
private ConnectionPool connectionPool;
http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/blob/f6b0ec6c/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Cluster.java
----------------------------------------------------------------------
diff --git a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Cluster.java b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Cluster.java
index 574cedd..46bc33e 100644
--- a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Cluster.java
+++ b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Cluster.java
@@ -49,7 +49,7 @@ import java.util.stream.Collectors;
*
* @author Stephen Mallette (http://stephen.genoprime.com)
*/
-public class Cluster {
+public final class Cluster {
private Manager manager;
http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/blob/f6b0ec6c/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Connection.java
----------------------------------------------------------------------
diff --git a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Connection.java b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Connection.java
index dccc0c2..a8538ae 100644
--- a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Connection.java
+++ b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Connection.java
@@ -42,7 +42,7 @@ import java.util.concurrent.atomic.AtomicReference;
*
* @author Stephen Mallette (http://stephen.genoprime.com)
*/
-class Connection {
+final class Connection {
private static final Logger logger = LoggerFactory.getLogger(Connection.class);
private final Channel channel;
http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/blob/f6b0ec6c/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/ConnectionPool.java
----------------------------------------------------------------------
diff --git a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/ConnectionPool.java b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/ConnectionPool.java
index 9ea3db6..7236e8c 100644
--- a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/ConnectionPool.java
+++ b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/ConnectionPool.java
@@ -40,7 +40,7 @@ import java.util.concurrent.locks.ReentrantLock;
/**
* @author Stephen Mallette (http://stephen.genoprime.com)
*/
-class ConnectionPool {
+final class ConnectionPool {
private static final Logger logger = LoggerFactory.getLogger(ConnectionPool.class);
public static final int MIN_POOL_SIZE = 2;
http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/blob/f6b0ec6c/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Handler.java
----------------------------------------------------------------------
diff --git a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Handler.java b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Handler.java
index 8b721ae..a4b1279 100644
--- a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Handler.java
+++ b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Handler.java
@@ -34,7 +34,7 @@ import java.util.concurrent.ConcurrentMap;
*
* @author Stephen Mallette (http://stephen.genoprime.com)
*/
-class Handler {
+final class Handler {
/**
* Takes a map of requests pending responses and writes responses to the {@link ResultQueue} of a request
http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/blob/f6b0ec6c/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Host.java
----------------------------------------------------------------------
diff --git a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Host.java b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Host.java
index 7ed7e4f..0e00817 100644
--- a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Host.java
+++ b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Host.java
@@ -32,7 +32,7 @@ import java.util.function.Function;
/**
* @author Stephen Mallette (http://stephen.genoprime.com)
*/
-class Host {
+final class Host {
private static final Logger logger = LoggerFactory.getLogger(Host.class);
private final InetSocketAddress address;
private final URI hostUri;
http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/blob/f6b0ec6c/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Result.java
----------------------------------------------------------------------
diff --git a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Result.java b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Result.java
index bb3bf44..08ab3db 100644
--- a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Result.java
+++ b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Result.java
@@ -28,7 +28,7 @@ import org.apache.tinkerpop.gremlin.structure.Vertex;
*
* @author Stephen Mallette (http://stephen.genoprime.com)
*/
-public class Result {
+public final class Result {
final Object resultObject;
/**
http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/blob/f6b0ec6c/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/ResultQueue.java
----------------------------------------------------------------------
diff --git a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/ResultQueue.java b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/ResultQueue.java
index 35eaffe..5f1022f 100644
--- a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/ResultQueue.java
+++ b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/ResultQueue.java
@@ -32,7 +32,7 @@ import java.util.concurrent.atomic.AtomicReference;
*
* @author Stephen Mallette (http://stephen.genoprime.com)
*/
-class ResultQueue {
+final class ResultQueue {
public enum Status {
FETCHING,
COMPLETE
http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/blob/f6b0ec6c/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/ResultSet.java
----------------------------------------------------------------------
diff --git a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/ResultSet.java b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/ResultSet.java
index 889864f..9f987bc 100644
--- a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/ResultSet.java
+++ b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/ResultSet.java
@@ -40,7 +40,7 @@ import java.util.stream.StreamSupport;
*
* @author Stephen Mallette (http://stephen.genoprime.com)
*/
-public class ResultSet implements Iterable<Result> {
+public final class ResultSet implements Iterable<Result> {
private final ResultQueue resultQueue;
private final ExecutorService executor;
private final Channel channel;