You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2023/11/01 22:41:36 UTC

[Impala-ASF-CR] IMPALA-12528: Deflake test hdfs scanner thread non reserved bytes

Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20640 )

Change subject: IMPALA-12528: Deflake test_hdfs_scanner_thread_non_reserved_bytes
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20640/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/20640/2//COMMIT_MSG@12
PS2, Line 12: running it serially and skip it in dockerized
            : environment
Injecting sleep on scanner thread should further harden this test, like this one:
https://github.com/apache/impala/blob/09f15eea78e54464699cf7e42b4433d5b74e8231/be/src/exec/hdfs-scan-node.cc#L443-L444

Maybe somewhere after obtaining scan range.



-- 
To view, visit http://gerrit.cloudera.org:8080/20640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5715cf16c87ff0de51afd2fa778c5b591409d376
Gerrit-Change-Number: 20640
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Nov 2023 22:41:36 +0000
Gerrit-HasComments: Yes