[GitHub] [helix] dasahcc commented on a change in pull request #1231: Terminal State Job Purging

[GitBox <gi...@apache.org>]

dasahcc commented on a change in pull request #1231:
URL: https://github.com/apache/helix/pull/1231#discussion_r467204323



##########
File path: helix-core/src/main/java/org/apache/helix/task/JobConfig.java
##########
@@ -147,10 +147,17 @@
     StartTime,
 
     /**
-     * The expiration time for the job
+     * The expiration time for the job if it's completed; once the expiry is reached and the job is
+     * completed, the job will be purged
      */
     Expiry,
 
+    /**
+     * The expiration time for the job if it's failed or timed out; once the expiry is reached and
+     * the job has failed or timed out, the job will be purged
+     */
+    TerminalStateExpiry,

Review comment:
       This may not be a good idea for that. It means user has to add a new config for each their job. And the existing running jobs and tasks are not benefiting from that.
   
   If we really want to support that, my suggestion is to have a global TASK config similar to cluster config. Let them enable for failed/timeout job purge. That would be much easier for user.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org