You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2017/06/14 11:29:16 UTC

Review Request 60077: Add https support to local metrics aggregator application

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60077/
-----------------------------------------------------------

Review request for Ambari, Aravindan Vijayan and Sid Wagle.


Bugs: AMBARI-21244
    https://issues.apache.org/jira/browse/AMBARI-21244


Repository: ambari


Description
-------

Add https support to local metrics aggregator application


Diffs
-----

  ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/metrics/LogFeederAMSClient.java 39526a5 
  ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java 644d978 
  ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/availability/AbstractTimelineMetricSinkTest.java ce2cf79 
  ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHATest.java f0174d5 
  ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/cache/HandleConnectExceptionTest.java 4eb75eb 
  ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java 6277907 
  ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java a290ced 
  ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java 30c5c23 
  ambari-metrics/ambari-metrics-host-aggregator/pom.xml 24432dd 
  ambari-metrics/ambari-metrics-host-aggregator/src/main/java/org/apache/hadoop/metrics2/host/aggregator/AggregatorApplication.java 1e5cc82 
  ambari-metrics/ambari-metrics-host-aggregator/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractMetricPublisher.java 5af115f 
  ambari-metrics/ambari-metrics-host-aggregator/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AggregatedMetricsPublisher.java c8dffab 
  ambari-metrics/ambari-metrics-host-aggregator/src/main/java/org/apache/hadoop/metrics2/sink/timeline/RawMetricsPublisher.java 89addb7 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/aggregator.py ba05e9b 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py d1429ed 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py 77b8c23 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/host_info.py 035c833 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/stop_handler.py 7a9fbec 
  ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java 6f5e9e0 
  ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java d408e1a 
  ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java ff72f24 
  ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java 5b75065 
  ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java 4d5a229 
  ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java 7dec18f 
  ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py 5d21514 
  ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/templates/hadoop-metrics2-accumulo.properties.j2 e59ba11 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml 1b085f6 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py f49d47d 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py b8c14f4 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hadoop-metrics2-hbase.properties.j2 978b795 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2 b7dee50 
  ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py 0e0c9aa 
  ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/templates/flume-metrics2.properties.j2 c476019 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py d45aea6 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-MASTER.j2 7368ffe 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-RS.j2 f245365 
  ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hadoop-metrics2.properties.xml 84ea231 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py f680799 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hivemetastore.properties.j2 3093e56 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hiveserver2.properties.j2 59a7c1b 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llapdaemon.j2 69f6071 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llaptaskscheduler.j2 c08a498 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/params_linux.py 91f10d8 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-hivemetastore.properties.j2 3093e56 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-hiveserver2.properties.j2 59a7c1b 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-llapdaemon.j2 69f6071 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-llaptaskscheduler.j2 c08a498 
  ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml 39dfeba 
  ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py 9acc1ef 
  ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py 664c582 
  ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/config.yaml.j2 b2dd3c8 
  ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm-metrics2.properties.j2 e7db91e 
  ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/package/scripts/params_linux.py 664c582 
  ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/package/templates/config.yaml.j2 b2dd3c8 
  ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/package/templates/storm-metrics2.properties.j2 e7db91e 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 3488e75 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/hadoop-metrics2.properties.j2 2cd9aa8 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-metrics2.properties.xml 84ea231 
  ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-START/scripts/params.py a3830f7 
  ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-START/templates/hadoop-metrics2.properties.j2 2cd9aa8 
  ambari-server/src/test/java/org/apache/ambari/server/metric/system/impl/TestAmbariMetricsSinkImpl.java 969070d 
  ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_monitor.py PRE-CREATION 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_ams_embedded.json 71423c8 
  contrib/management-packs/hdf-ambari-mpack/src/main/resources/stacks/HDF/2.0/hooks/before-START/scripts/params.py 8cc876f 


Diff: https://reviews.apache.org/r/60077/diff/1/


Testing
-------

Unit tests passed


Thanks,

Dmytro Sen


Re: Review Request 60077: Add https support to local metrics aggregator application

Posted by Aravindan Vijayan <av...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60077/#review178428
-----------------------------------------------------------


Ship it!




Ship It!

- Aravindan Vijayan


On June 20, 2017, 12:51 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60077/
> -----------------------------------------------------------
> 
> (Updated June 20, 2017, 12:51 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan and Sid Wagle.
> 
> 
> Bugs: AMBARI-21244
>     https://issues.apache.org/jira/browse/AMBARI-21244
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add https support to local metrics aggregator application
> 
> 
> Diffs
> -----
> 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/metrics/LogFeederAMSClient.java 39526a5 
>   ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java 7a84627 
>   ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/availability/AbstractTimelineMetricSinkTest.java ce2cf79 
>   ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHATest.java f0174d5 
>   ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/cache/HandleConnectExceptionTest.java 4eb75eb 
>   ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java 6277907 
>   ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java a290ced 
>   ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java 30c5c23 
>   ambari-metrics/ambari-metrics-host-aggregator/pom.xml 24432dd 
>   ambari-metrics/ambari-metrics-host-aggregator/src/main/java/org/apache/hadoop/metrics2/host/aggregator/AggregatorApplication.java 1e5cc82 
>   ambari-metrics/ambari-metrics-host-aggregator/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractMetricPublisher.java 5af115f 
>   ambari-metrics/ambari-metrics-host-aggregator/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AggregatedMetricsPublisher.java c8dffab 
>   ambari-metrics/ambari-metrics-host-aggregator/src/main/java/org/apache/hadoop/metrics2/sink/timeline/RawMetricsPublisher.java 89addb7 
>   ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/aggregator.py ba05e9b 
>   ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py d1429ed 
>   ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py 77b8c23 
>   ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/host_info.py 035c833 
>   ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/stop_handler.py 7a9fbec 
>   ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java 6f5e9e0 
>   ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java d408e1a 
>   ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java ff72f24 
>   ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java 5b75065 
>   ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java 4d5a229 
>   ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java 7dec18f 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py 14c1682 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/templates/hadoop-metrics2-accumulo.properties.j2 e59ba11 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml 1b085f6 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py f49d47d 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py b8c14f4 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hadoop-metrics2-hbase.properties.j2 978b795 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2 b7dee50 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py 0e0c9aa 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/templates/flume-metrics2.properties.j2 c476019 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py d45aea6 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-MASTER.j2 7368ffe 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-RS.j2 f245365 
>   ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hadoop-metrics2.properties.xml 84ea231 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 078076a 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hivemetastore.properties.j2 3093e56 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hiveserver2.properties.j2 59a7c1b 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llapdaemon.j2 69f6071 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llaptaskscheduler.j2 c08a498 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/params_linux.py 77206e7 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-hivemetastore.properties.j2 3093e56 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-hiveserver2.properties.j2 59a7c1b 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-llapdaemon.j2 69f6071 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-llaptaskscheduler.j2 c08a498 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml 39dfeba 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py 9acc1ef 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py 664c582 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/config.yaml.j2 b2dd3c8 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm-metrics2.properties.j2 e7db91e 
>   ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/package/scripts/params_linux.py 664c582 
>   ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/package/templates/config.yaml.j2 b2dd3c8 
>   ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/package/templates/storm-metrics2.properties.j2 e7db91e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 3488e75 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/hadoop-metrics2.properties.j2 2cd9aa8 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-metrics2.properties.xml 84ea231 
>   ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-START/scripts/params.py a3830f7 
>   ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-START/templates/hadoop-metrics2.properties.j2 2cd9aa8 
>   ambari-server/src/test/java/org/apache/ambari/server/metric/system/impl/TestAmbariMetricsSinkImpl.java 969070d 
>   ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_monitor.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_ams_embedded.json 71423c8 
>   contrib/management-packs/hdf-ambari-mpack/src/main/resources/stacks/HDF/2.0/hooks/before-START/scripts/params.py 8cc876f 
> 
> 
> Diff: https://reviews.apache.org/r/60077/diff/2/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Re: Review Request 60077: Add https support to local metrics aggregator application

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60077/
-----------------------------------------------------------

(Updated Июнь 20, 2017, 12:51 п.п.)


Review request for Ambari, Aravindan Vijayan and Sid Wagle.


Bugs: AMBARI-21244
    https://issues.apache.org/jira/browse/AMBARI-21244


Repository: ambari


Description
-------

Add https support to local metrics aggregator application


Diffs (updated)
-----

  ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/metrics/LogFeederAMSClient.java 39526a5 
  ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java 7a84627 
  ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/availability/AbstractTimelineMetricSinkTest.java ce2cf79 
  ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHATest.java f0174d5 
  ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/cache/HandleConnectExceptionTest.java 4eb75eb 
  ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java 6277907 
  ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java a290ced 
  ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java 30c5c23 
  ambari-metrics/ambari-metrics-host-aggregator/pom.xml 24432dd 
  ambari-metrics/ambari-metrics-host-aggregator/src/main/java/org/apache/hadoop/metrics2/host/aggregator/AggregatorApplication.java 1e5cc82 
  ambari-metrics/ambari-metrics-host-aggregator/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractMetricPublisher.java 5af115f 
  ambari-metrics/ambari-metrics-host-aggregator/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AggregatedMetricsPublisher.java c8dffab 
  ambari-metrics/ambari-metrics-host-aggregator/src/main/java/org/apache/hadoop/metrics2/sink/timeline/RawMetricsPublisher.java 89addb7 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/aggregator.py ba05e9b 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py d1429ed 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py 77b8c23 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/host_info.py 035c833 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/stop_handler.py 7a9fbec 
  ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java 6f5e9e0 
  ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java d408e1a 
  ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java ff72f24 
  ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java 5b75065 
  ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java 4d5a229 
  ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java 7dec18f 
  ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py 14c1682 
  ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/templates/hadoop-metrics2-accumulo.properties.j2 e59ba11 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml 1b085f6 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py f49d47d 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py b8c14f4 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hadoop-metrics2-hbase.properties.j2 978b795 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2 b7dee50 
  ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py 0e0c9aa 
  ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/templates/flume-metrics2.properties.j2 c476019 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py d45aea6 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-MASTER.j2 7368ffe 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-RS.j2 f245365 
  ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hadoop-metrics2.properties.xml 84ea231 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 078076a 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hivemetastore.properties.j2 3093e56 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hiveserver2.properties.j2 59a7c1b 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llapdaemon.j2 69f6071 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llaptaskscheduler.j2 c08a498 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/params_linux.py 77206e7 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-hivemetastore.properties.j2 3093e56 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-hiveserver2.properties.j2 59a7c1b 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-llapdaemon.j2 69f6071 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-llaptaskscheduler.j2 c08a498 
  ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml 39dfeba 
  ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py 9acc1ef 
  ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py 664c582 
  ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/config.yaml.j2 b2dd3c8 
  ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm-metrics2.properties.j2 e7db91e 
  ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/package/scripts/params_linux.py 664c582 
  ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/package/templates/config.yaml.j2 b2dd3c8 
  ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/package/templates/storm-metrics2.properties.j2 e7db91e 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 3488e75 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/hadoop-metrics2.properties.j2 2cd9aa8 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-metrics2.properties.xml 84ea231 
  ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-START/scripts/params.py a3830f7 
  ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-START/templates/hadoop-metrics2.properties.j2 2cd9aa8 
  ambari-server/src/test/java/org/apache/ambari/server/metric/system/impl/TestAmbariMetricsSinkImpl.java 969070d 
  ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_monitor.py PRE-CREATION 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_ams_embedded.json 71423c8 
  contrib/management-packs/hdf-ambari-mpack/src/main/resources/stacks/HDF/2.0/hooks/before-START/scripts/params.py 8cc876f 


Diff: https://reviews.apache.org/r/60077/diff/2/

Changes: https://reviews.apache.org/r/60077/diff/1-2/


Testing
-------

Unit tests passed


Thanks,

Dmytro Sen