You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Travis Crawford (JIRA)" <ji...@apache.org> on 2012/04/24 21:53:35 UTC
[jira] [Commented] (HIVE-2424) Don't expose thrift, commons and
json classes in the hive exec jar
[ https://issues.apache.org/jira/browse/HIVE-2424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13260886#comment-13260886 ]
Travis Crawford commented on HIVE-2424:
---------------------------------------
Looking at [ql/build.xml|http://svn.apache.org/viewvc/hive/trunk/ql/build.xml?view=markup] we see the jar target extracts thrift (and commons-lang, json, javaewah), then bundles them into {{hive-exec.jar}}.
What's the reason for treating these four jars differently, bundling them inside hive-exec? They're already available in the lib directory like other dependencies.
Any objections to making a patch that stops bundling these 3rd-party jars inside hive-exec? This would require users to add the jars to their classpath, which they're likely already doing as they're included in the lib directory with other necessary dependencies. I don't believe making this fat jar is necessary (or I don't understand the use-case).
If this sounds good I can post the patch.
> Don't expose thrift, commons and json classes in the hive exec jar
> -------------------------------------------------------------------
>
> Key: HIVE-2424
> URL: https://issues.apache.org/jira/browse/HIVE-2424
> Project: Hive
> Issue Type: Improvement
> Components: Build Infrastructure
> Reporter: Eli Collins
>
> The hive exec jar includes exploded thrift, json, and commons lang classes. These may conflict with the user's classpath. This could be fixed by jar jaring or using shade. A mechanism that allowed a user to substitute alternative versions w/o recompiling might be a useful intermediate step (though will require the user substitute alternative versions that work w/ Hive).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira