[jira] [Resolved] (SSHD-504) UserAuthKeyboardInteractive fails to match if prompt doesn't start password

["Goldstein Lyor (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SSHD-504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Goldstein Lyor resolved SSHD-504.
---------------------------------
       Resolution: Fixed
    Fix Version/s: 1.0.0

Fixed in 1.0 - made the logic as follows

* the word _"password"_ *must* exist in the prompt
* the colon (\:) delimiter *must* exist in the prompt
* the *last* position of the colon must be *after* the *last* position of the _"password"_ keyword

At the same time added various _protected_ methods that enable users to override the built-in behavior more easily should they need to

> UserAuthKeyboardInteractive fails to match if prompt doesn't start password
> ---------------------------------------------------------------------------
>
>                 Key: SSHD-504
>                 URL: https://issues.apache.org/jira/browse/SSHD-504
>             Project: MINA SSHD
>          Issue Type: Bug
>    Affects Versions: 0.13.0
>            Reporter: Matt Kusnierz
>            Assignee: Goldstein Lyor
>             Fix For: 1.0.0
>
>
> This method: org.apache.sshd.client.auth.UserAuthKeyboardInteractive.process(Buffer)
> line 116
> contains a check on the prompt:
> prompt[0].toLowerCase().startsWith("password:")
> This doesn't always work. My server's for instance prompt "{username}'s password:" and so this check fails.
> Maybe an endsWith "password:" would work better? or a contains password check?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)