You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@buildr.apache.org by Ittay Dror <it...@gmail.com> on 2008/11/03 13:57:50 UTC

bug in ArchiveTask#needed? ?

this is some of the code of the method:

    most_recent = @paths.collect { |name, path| path.sources }.flatten

        each { |src| File.directory?(src) ? 
Util.recursive_with_dot_files(src) | [src] : src }.flatten.
        select { |file| File.exist?(file) }.collect { |file| 
File.stat(file).mtime }.max
      File.stat(name).mtime < (most_recent || Rake::EARLY) || super


isn't the 'each' call effectively a noop (being that each just returns 
the same array)?

ittay

-- 
--
Ittay Dror <it...@gmail.com>

Re: bug in ArchiveTask#needed? ?

Posted by Assaf Arkin <ar...@intalio.com>.

I believe so.

Assaf

On Mon, Nov 3, 2008 at 4:57 AM, Ittay Dror <it...@gmail.com> wrote:
> this is some of the code of the method:
>
>   most_recent = @paths.collect { |name, path| path.sources }.flatten
>
>       each { |src| File.directory?(src) ? Util.recursive_with_dot_files(src)
> | [src] : src }.flatten.
>       select { |file| File.exist?(file) }.collect { |file|
> File.stat(file).mtime }.max
>     File.stat(name).mtime < (most_recent || Rake::EARLY) || super
>
>
> isn't the 'each' call effectively a noop (being that each just returns the
> same array)?
>
> ittay
>
> --
> --
> Ittay Dror <it...@gmail.com>
>
>
>