You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Jonathan Locke (JIRA)" <ji...@apache.org> on 2007/06/19 03:49:26 UTC
[jira] Created: (WICKET-670) Bring back the inspector!
Bring back the inspector!
-------------------------
Key: WICKET-670
URL: https://issues.apache.org/jira/browse/WICKET-670
Project: Wicket
Issue Type: Wish
Components: wicket
Affects Versions: 1.4.0-alpha
Reporter: Jonathan Locke
Priority: Minor
Fix For: 1.4.0-alpha
My copy of the inspector is completely broken. It's a shame that this useful tool is not really supported anymore. It gives people a sense of confidence when they can navigate their wicket session and see all the components with the inspector.
To bring the inspector back, we could do the following things:
1. fix the inspector
- it needs to factor out the stack trace metadata so sizes of things are more accurate
- my inspector causes every page viewed after using it to fail with a page expired exception (!)
2. add a security setting setInspectorEnabled() which defaults to false (disabled) and unless
the inspector is explicitly enabled, the constructor of every publicly accessible bookmarkable
page in the inspector package throws an IllegalStateException() with an explanation of what
you must do to safely use the inspector in your application (add security to the pages via
wicket-auth-roles or some other means and call setInspectorEnabled(true)).
then we can all enjoy the return of the inspector!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-670) Bring back the inspector!
Posted by "Jonathan Locke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12506007 ]
Jonathan Locke commented on WICKET-670:
---------------------------------------
yeah, we should make it clear on the page that it's a best estimate and what
that best estimate is based on (serialization size in this case).
there isn't really a working panel and a panel would require a bit more work
because an inspector panel would affect the page it's on and also would need
to be pretty ajaxy to let you drill down into the session and so forth. it's been
a long time since i wrote that inspector though so maybe it's time to rethink it
in terms of an ajax tree or something. we did not have that option back in those
days. anyway, i agree a panel would be nice, but i'd be happy enough with
just a safe, working page. certainly it would be a fun independent project
for someone to do a rewrite or a major refactor of what we've got.
> Bring back the inspector!
> -------------------------
>
> Key: WICKET-670
> URL: https://issues.apache.org/jira/browse/WICKET-670
> Project: Wicket
> Issue Type: Wish
> Components: wicket
> Affects Versions: 1.4.0-alpha
> Reporter: Jonathan Locke
> Priority: Minor
> Fix For: 1.4.0-alpha
>
>
> My copy of the inspector is completely broken. It's a shame that this useful tool is not really supported anymore. It gives people a sense of confidence when they can navigate their wicket session and see all the components with the inspector.
> To bring the inspector back, we could do the following things:
> 1. fix the inspector
> - it needs to factor out the stack trace metadata so sizes of things are more accurate
> - my inspector causes every page viewed after using it to fail with a page expired exception (!)
> 2. add a security setting setInspectorEnabled() which defaults to false (disabled) and unless
> the inspector is explicitly enabled, the constructor of every publicly accessible bookmarkable
> page in the inspector package throws an IllegalStateException() with an explanation of what
> you must do to safely use the inspector in your application (add security to the pages via
> wicket-auth-roles or some other means and call setInspectorEnabled(true)).
> then we can all enjoy the return of the inspector!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-670) Bring back the inspector!
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12506021 ]
Eelco Hillenius commented on WICKET-670:
----------------------------------------
Another alternative would be to put such a page in a separate project. If you include the project, you have the page.
> Bring back the inspector!
> -------------------------
>
> Key: WICKET-670
> URL: https://issues.apache.org/jira/browse/WICKET-670
> Project: Wicket
> Issue Type: Wish
> Components: wicket
> Affects Versions: 1.4.0-alpha
> Reporter: Jonathan Locke
> Priority: Minor
> Fix For: 1.4.0-alpha
>
>
> My copy of the inspector is completely broken. It's a shame that this useful tool is not really supported anymore. It gives people a sense of confidence when they can navigate their wicket session and see all the components with the inspector.
> To bring the inspector back, we could do the following things:
> 1. fix the inspector
> - it needs to factor out the stack trace metadata so sizes of things are more accurate
> - my inspector causes every page viewed after using it to fail with a page expired exception (!)
> 2. add a security setting setInspectorEnabled() which defaults to false (disabled) and unless
> the inspector is explicitly enabled, the constructor of every publicly accessible bookmarkable
> page in the inspector package throws an IllegalStateException() with an explanation of what
> you must do to safely use the inspector in your application (add security to the pages via
> wicket-auth-roles or some other means and call setInspectorEnabled(true)).
> then we can all enjoy the return of the inspector!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-670) Bring back the inspector!
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12506004 ]
Eelco Hillenius commented on WICKET-670:
----------------------------------------
> It gives people a sense of confidence when they can navigate their wicket session and see all the components with the inspector.
I'm still not completely sure how acurate the picture is we are displaying there. When I did testing I found there was a big difference between how many users I could support with a certain ammount of MBs based on what the inspector says and how much memory I actually consumed when I tested with that number of sessions. Gladly, always in favor of the real situation. This is even true when you include the wicket-objectsizeof-agent project for your measurings, which should give a much better estimate anyway.
Anyway... I agree it is a nice toy and it would be nice to have this available for people as long as they understand that it's best estimates rather than a hard numbers they are seeing.
> 1. fix the inspector
>
> - it needs to factor out the stack trace metadata so sizes of things are more accurate
Stack trace meta data is removed at the end of requests, so the only polluted number you are seeing might be of the inspector page itself.
> 2. add a security setting setInspectorEnabled() which defaults to false (disabled) and unless
> the inspector is explicitly enabled, the constructor of every publicly accessible bookmarkable
> page in the inspector package throws an IllegalStateException() ...
I think it is a better idea to ship just the inspector panel, not the page. That way people can decide for themselves how to include and protect it, and we don't have to litter our settings any more :).
> Bring back the inspector!
> -------------------------
>
> Key: WICKET-670
> URL: https://issues.apache.org/jira/browse/WICKET-670
> Project: Wicket
> Issue Type: Wish
> Components: wicket
> Affects Versions: 1.4.0-alpha
> Reporter: Jonathan Locke
> Priority: Minor
> Fix For: 1.4.0-alpha
>
>
> My copy of the inspector is completely broken. It's a shame that this useful tool is not really supported anymore. It gives people a sense of confidence when they can navigate their wicket session and see all the components with the inspector.
> To bring the inspector back, we could do the following things:
> 1. fix the inspector
> - it needs to factor out the stack trace metadata so sizes of things are more accurate
> - my inspector causes every page viewed after using it to fail with a page expired exception (!)
> 2. add a security setting setInspectorEnabled() which defaults to false (disabled) and unless
> the inspector is explicitly enabled, the constructor of every publicly accessible bookmarkable
> page in the inspector package throws an IllegalStateException() with an explanation of what
> you must do to safely use the inspector in your application (add security to the pages via
> wicket-auth-roles or some other means and call setInspectorEnabled(true)).
> then we can all enjoy the return of the inspector!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-670) Bring back the inspector!
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12506081 ]
Johan Compagner commented on WICKET-670:
----------------------------------------
Inspector page seems to work fine i if go over the examples
(at least i don't get a page expired)
one problem i do see. Pages are not really listed there i guess that is because of the second level cache
and the way it stores pages.
> Bring back the inspector!
> -------------------------
>
> Key: WICKET-670
> URL: https://issues.apache.org/jira/browse/WICKET-670
> Project: Wicket
> Issue Type: Wish
> Components: wicket
> Affects Versions: 1.4.0-alpha
> Reporter: Jonathan Locke
> Priority: Minor
> Fix For: 1.4.0-alpha
>
>
> My copy of the inspector is completely broken. It's a shame that this useful tool is not really supported anymore. It gives people a sense of confidence when they can navigate their wicket session and see all the components with the inspector.
> To bring the inspector back, we could do the following things:
> 1. fix the inspector
> - it needs to factor out the stack trace metadata so sizes of things are more accurate
> - my inspector causes every page viewed after using it to fail with a page expired exception (!)
> 2. add a security setting setInspectorEnabled() which defaults to false (disabled) and unless
> the inspector is explicitly enabled, the constructor of every publicly accessible bookmarkable
> page in the inspector package throws an IllegalStateException() with an explanation of what
> you must do to safely use the inspector in your application (add security to the pages via
> wicket-auth-roles or some other means and call setInspectorEnabled(true)).
> then we can all enjoy the return of the inspector!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.