You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pivot.apache.org by Scott Lanham <li...@sael.com.au> on 2009/09/16 02:15:45 UTC

Custom TableViewRowEditor

Hi Guys,

A Todd suggestion I have joined the dev list.

I had to do a quick and dirty hack to TableViewRowEditor to get it to fire a 
"Cancel" event when the escape key is hit. The Code is attached in case you 
are interested.

Please let me know if you don't want me posting this kind of stuff on this 
list.

Cheers,

Scott.

Re: Custom TableViewRowEditor

Posted by Scott Lanham <li...@sael.com.au>.
I Posted too soon. This hack no longer works.

On Wed, 16 Sep 2009 10:15:45 am Scott Lanham wrote:
> Hi Guys,
>
> A Todd suggestion I have joined the dev list.
>
> I had to do a quick and dirty hack to TableViewRowEditor to get it to fire
> a "Cancel" event when the escape key is hit. The Code is attached in case
> you are interested.
>
> Please let me know if you don't want me posting this kind of stuff on this
> list.
>
> Cheers,
>
> Scott.


Re: Custom TableViewRowEditor

Posted by Todd Volkert <tv...@gmail.com>.
I noticed that after I sent the email :)

On Tue, Sep 15, 2009 at 9:40 PM, Scott Lanham <li...@sael.com.au> wrote:

> No problem with using diffs. The code in this case didn't involve changes
> to
> Pivot though :-)
>
> On Wed, 16 Sep 2009 11:37:47 am Todd Volkert wrote:
> > Hi Scott,
> > Welcome to the dev list!  Posting this kind of stuff is great, though
> > posting it in a diff format is generally preferable, because it (a) makes
> > it easier to see what actually changed, and (b) makes it easy to
> > incorporate your changes into the platform via the 'patch' command.  You
> > can run 'svn diff > patch.txt' at  the command line to get the output in
> a
> > diff format.
> >
> > Cheers,
> > -T
> >
> > On Tue, Sep 15, 2009 at 8:15 PM, Scott Lanham <li...@sael.com.au> wrote:
> > > Hi Guys,
> > >
> > > A Todd suggestion I have joined the dev list.
> > >
> > > I had to do a quick and dirty hack to TableViewRowEditor to get it to
> > > fire a
> > > "Cancel" event when the escape key is hit. The Code is attached in case
> > > you are interested.
> > >
> > > Please let me know if you don't want me posting this kind of stuff on
> > > this list.
> > >
> > > Cheers,
> > >
> > > Scott.
>
>

Re: Custom TableViewRowEditor

Posted by Scott Lanham <li...@sael.com.au>.
No problem with using diffs. The code in this case didn't involve changes to 
Pivot though :-)

On Wed, 16 Sep 2009 11:37:47 am Todd Volkert wrote:
> Hi Scott,
> Welcome to the dev list!  Posting this kind of stuff is great, though
> posting it in a diff format is generally preferable, because it (a) makes
> it easier to see what actually changed, and (b) makes it easy to
> incorporate your changes into the platform via the 'patch' command.  You
> can run 'svn diff > patch.txt' at  the command line to get the output in a
> diff format.
>
> Cheers,
> -T
>
> On Tue, Sep 15, 2009 at 8:15 PM, Scott Lanham <li...@sael.com.au> wrote:
> > Hi Guys,
> >
> > A Todd suggestion I have joined the dev list.
> >
> > I had to do a quick and dirty hack to TableViewRowEditor to get it to
> > fire a
> > "Cancel" event when the escape key is hit. The Code is attached in case
> > you are interested.
> >
> > Please let me know if you don't want me posting this kind of stuff on
> > this list.
> >
> > Cheers,
> >
> > Scott.


Re: Custom TableViewRowEditor

Posted by Todd Volkert <tv...@gmail.com>.
Hi Scott,
Welcome to the dev list!  Posting this kind of stuff is great, though
posting it in a diff format is generally preferable, because it (a) makes it
easier to see what actually changed, and (b) makes it easy to incorporate
your changes into the platform via the 'patch' command.  You can run 'svn
diff > patch.txt' at  the command line to get the output in a diff format.

Cheers,
-T

On Tue, Sep 15, 2009 at 8:15 PM, Scott Lanham <li...@sael.com.au> wrote:

> Hi Guys,
>
> A Todd suggestion I have joined the dev list.
>
> I had to do a quick and dirty hack to TableViewRowEditor to get it to fire
> a
> "Cancel" event when the escape key is hit. The Code is attached in case you
> are interested.
>
> Please let me know if you don't want me posting this kind of stuff on this
> list.
>
> Cheers,
>
> Scott.
>

Re: Custom TableViewRowEditor

Posted by Scott Lanham <li...@sael.com.au>.
Very very cool. I can now get the save button to deactivate when the escape 
key is hit. How easy is it to please a programmer!

On Fri, 18 Sep 2009 04:00:26 am Todd Volkert wrote:
> Ok, Scott -- TableViewRowEditor now has its events wired up - give it a
> shot!
>
> On Wed, Sep 16, 2009 at 6:32 PM, Todd Volkert <tv...@gmail.com> wrote:
> > Yeah that's yet to be done.  The event handlers are defined and the
> > listener lists are set up, but none of the events fire yet :)  Shouldn't
> > be too tough - I'll try to do it in a day or so unless you want to tackle
> > it first :)
> > -T
> >
> > On Wed, Sep 16, 2009 at 4:35 PM, Scott Lanham <li...@sael.com.au> wrote:
> >> Thanks Todd, that has saved me a heap of QAD hacks :-)
> >>
> >> The editCancelled event isn't firing for me. Is that yet to be done?
> >>
> >> On Thu, 17 Sep 2009 04:00:30 am Todd Volkert wrote:
> >> > Scott, this change inspired PIVOT-299, which is partially implemented
> >>
> >> now
> >>
> >> > when you sync.  Note that the editor API changed slightly - as
> >> > outlined
> >>
> >> in
> >>
> >> > the JIRA ticket.
> >> >
> >> > -T
> >> >
> >> > On Tue, Sep 15, 2009 at 8:15 PM, Scott Lanham <li...@sael.com.au>
> >>
> >> wrote:
> >> > > Hi Guys,
> >> > >
> >> > > A Todd suggestion I have joined the dev list.
> >> > >
> >> > > I had to do a quick and dirty hack to TableViewRowEditor to get it
> >> > > to fire a
> >> > > "Cancel" event when the escape key is hit. The Code is attached in
> >>
> >> case
> >>
> >> > > you are interested.
> >> > >
> >> > > Please let me know if you don't want me posting this kind of stuff
> >> > > on this list.
> >> > >
> >> > > Cheers,
> >> > >
> >> > > Scott.


Re: Custom TableViewRowEditor

Posted by Todd Volkert <tv...@gmail.com>.
Ok, Scott -- TableViewRowEditor now has its events wired up - give it a
shot!

On Wed, Sep 16, 2009 at 6:32 PM, Todd Volkert <tv...@gmail.com> wrote:

> Yeah that's yet to be done.  The event handlers are defined and the
> listener lists are set up, but none of the events fire yet :)  Shouldn't be
> too tough - I'll try to do it in a day or so unless you want to tackle it
> first :)
> -T
>
>
> On Wed, Sep 16, 2009 at 4:35 PM, Scott Lanham <li...@sael.com.au> wrote:
>
>> Thanks Todd, that has saved me a heap of QAD hacks :-)
>>
>> The editCancelled event isn't firing for me. Is that yet to be done?
>>
>> On Thu, 17 Sep 2009 04:00:30 am Todd Volkert wrote:
>> > Scott, this change inspired PIVOT-299, which is partially implemented
>> now
>> > when you sync.  Note that the editor API changed slightly - as outlined
>> in
>> > the JIRA ticket.
>> >
>> > -T
>> >
>> > On Tue, Sep 15, 2009 at 8:15 PM, Scott Lanham <li...@sael.com.au>
>> wrote:
>> > > Hi Guys,
>> > >
>> > > A Todd suggestion I have joined the dev list.
>> > >
>> > > I had to do a quick and dirty hack to TableViewRowEditor to get it to
>> > > fire a
>> > > "Cancel" event when the escape key is hit. The Code is attached in
>> case
>> > > you are interested.
>> > >
>> > > Please let me know if you don't want me posting this kind of stuff on
>> > > this list.
>> > >
>> > > Cheers,
>> > >
>> > > Scott.
>>
>>
>

Re: Custom TableViewRowEditor

Posted by Todd Volkert <tv...@gmail.com>.
Yeah that's yet to be done.  The event handlers are defined and the listener
lists are set up, but none of the events fire yet :)  Shouldn't be too tough
- I'll try to do it in a day or so unless you want to tackle it first :)
-T

On Wed, Sep 16, 2009 at 4:35 PM, Scott Lanham <li...@sael.com.au> wrote:

> Thanks Todd, that has saved me a heap of QAD hacks :-)
>
> The editCancelled event isn't firing for me. Is that yet to be done?
>
> On Thu, 17 Sep 2009 04:00:30 am Todd Volkert wrote:
> > Scott, this change inspired PIVOT-299, which is partially implemented now
> > when you sync.  Note that the editor API changed slightly - as outlined
> in
> > the JIRA ticket.
> >
> > -T
> >
> > On Tue, Sep 15, 2009 at 8:15 PM, Scott Lanham <li...@sael.com.au> wrote:
> > > Hi Guys,
> > >
> > > A Todd suggestion I have joined the dev list.
> > >
> > > I had to do a quick and dirty hack to TableViewRowEditor to get it to
> > > fire a
> > > "Cancel" event when the escape key is hit. The Code is attached in case
> > > you are interested.
> > >
> > > Please let me know if you don't want me posting this kind of stuff on
> > > this list.
> > >
> > > Cheers,
> > >
> > > Scott.
>
>

Re: Custom TableViewRowEditor

Posted by Scott Lanham <li...@sael.com.au>.
Thanks Todd, that has saved me a heap of QAD hacks :-)

The editCancelled event isn't firing for me. Is that yet to be done?

On Thu, 17 Sep 2009 04:00:30 am Todd Volkert wrote:
> Scott, this change inspired PIVOT-299, which is partially implemented now
> when you sync.  Note that the editor API changed slightly - as outlined in
> the JIRA ticket.
>
> -T
>
> On Tue, Sep 15, 2009 at 8:15 PM, Scott Lanham <li...@sael.com.au> wrote:
> > Hi Guys,
> >
> > A Todd suggestion I have joined the dev list.
> >
> > I had to do a quick and dirty hack to TableViewRowEditor to get it to
> > fire a
> > "Cancel" event when the escape key is hit. The Code is attached in case
> > you are interested.
> >
> > Please let me know if you don't want me posting this kind of stuff on
> > this list.
> >
> > Cheers,
> >
> > Scott.


Re: Custom TableViewRowEditor

Posted by Todd Volkert <tv...@gmail.com>.
Scott, this change inspired PIVOT-299, which is partially implemented now
when you sync.  Note that the editor API changed slightly - as outlined in
the JIRA ticket.

-T

On Tue, Sep 15, 2009 at 8:15 PM, Scott Lanham <li...@sael.com.au> wrote:

> Hi Guys,
>
> A Todd suggestion I have joined the dev list.
>
> I had to do a quick and dirty hack to TableViewRowEditor to get it to fire
> a
> "Cancel" event when the escape key is hit. The Code is attached in case you
> are interested.
>
> Please let me know if you don't want me posting this kind of stuff on this
> list.
>
> Cheers,
>
> Scott.
>