You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@livy.apache.org by "nileshrathi345 (via GitHub)" <gi...@apache.org> on 2026/10/22 05:34:41 UTC
Re: [PR] [Livy-1091] Upgrade libthrift 0.9.3 to 0.25.0 and Hive to 4.0.1 for thriftserver [livy]
nileshrathi345 commented on code in PR #567:
URL: https://github.com/apache/livy/pull/567#discussion_r4344891583
##########
thriftserver/server/src/main/scala/org/apache/livy/thriftserver/cli/ThriftBinaryCLIService.scala:
##########
@@ -110,11 +110,9 @@ class ThriftBinaryCLIService(override val cliService: LivyCLIService, val oomHoo
new TBinaryProtocol.Factory(true, true, maxMessageSize, maxMessageSize))
.executorService(executorService)
// `requestTimeout`, `requestTimeoutUnit`, `beBackoffSlotLength` and
- // `beBackoffSlotLengthUnit` are present in the libthrift that Livy
- // compiles against (0.9.3, pinned in the root pom) and in the versions
- // Spark 3 brings in transitively, but were removed in libthrift 0.16.0
- // (transitively pulled in by Spark 4). Invoke them reflectively so the
- // same code compiles and runs on both classpaths.
+ // `beBackoffSlotLengthUnit` were removed in libthrift 0.16.0. Invoke them
+ // reflectively so the same binary still runs if an older libthrift is on
+ // the runtime classpath (e.g. Spark 3 transitive versions).
Review Comment:
Added comment on `livy.server.thrift.login.timeout` and `livy.server.thrift.exponential.backoff.slot.length` in `LivyConf.scala` noting they only apply to binary `TThreadPoolServer` and have no effect with libthrift 0.16.0+ (Livy 0.25.0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@livy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org