You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/31 19:10:11 UTC

[GitHub] [airflow] ryw opened a new pull request #10665: DRAFT: Experimentally remove unidecode

ryw opened a new pull request #10665:
URL: https://github.com/apache/airflow/pull/10665

<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.

Feel free to ping committers for the review!

In case of existing issue, reference it using one of the following:

closes: #ISSUE
related: #ISSUE

How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->

---
**^ Add meaningful description above**

Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ryw commented on pull request #10665: DRAFT: Experimentally remove unidecode

Posted by GitBox <gi...@apache.org>.

ryw commented on pull request #10665:
URL: https://github.com/apache/airflow/pull/10665#issuecomment-683999560


   i'm trying to understand the licensing risks we have in the project - and realized that perhaps we can just remove Unidecode from codebase - tests don't fail on this branch - can we remove?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ryw commented on pull request #10665: DRAFT: Experimentally remove unidecode

Posted by GitBox <gi...@apache.org>.

ryw commented on pull request #10665:
URL: https://github.com/apache/airflow/pull/10665#issuecomment-684011576


   Closing this in favor of #10668


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk edited a comment on pull request #10665: DRAFT: Experimentally remove unidecode

Posted by GitBox <gi...@apache.org>.

potiuk edited a comment on pull request #10665:
URL: https://github.com/apache/airflow/pull/10665#issuecomment-684008648

BTW. The vulnerability scanner will likely still show those dependencies, if it is actually working (I would love to hear if it does).

As explained, the dependencies in our project come from setup.py and unidecode is a transitive dependency (nothing changes by removing this file). So if it will not show unidecode as dependency, it means that it does not detect the "proper" ones..

FYI. Those "constraints" files for master are here https://github.com/apache/airflow/tree/constraints-master (you can see history of changes there) - they will show you the list of actual dependencies used by the project. They are refreshed automatically every time when master merge succeed. There are already 35 commits in there (1-2 changes a day). So if you want to have the latest "snapshot" of all dependencies used (including the transitive ones) you should look there (HEAD of "constraints-master" branch) in case the scanner is not able to do it from the "setup.py" automatically.

More about it here: https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pinned-constraint-files

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ryw commented on pull request #10665: DRAFT: Experimentally remove unidecode

Posted by GitBox <gi...@apache.org>.

ryw commented on pull request #10665:
URL: https://github.com/apache/airflow/pull/10665#issuecomment-684003525


   Thanks @potiuk who will remove these unused files + when?
   I'm responding to the output of our vulnerability scanner.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #10665: DRAFT: Experimentally remove unidecode

Posted by GitBox <gi...@apache.org>.

potiuk commented on pull request #10665:
URL: https://github.com/apache/airflow/pull/10665#issuecomment-684001008


   FYI. @ryw - those files are not used anymore (we were waiting for 1.10.12 to be released to remove them).  And the name is indeed misleading so no wonder you thought those are actual requirements. We are about to remove the whole directory (PR is coming). 
   
   They've been replaced with "constraint-master", "constraints-v1-10-test" and "constraints-v1-10-stable" orphaned branches, where we keep constraint files. 
   
   Even there - those are just "constraint" files rather than "requirements" - all the dependencies are coming from setup.py file and Unidecode there is a transitive dependency coming from 'python-nvd3~=0.15.0': python-nvd3 -> pytthon-alugify -> text-unidecode . You can see it by entering `breeze` and running `pipdeptree` and you will be able to see the whole dependency tree.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ryw closed pull request #10665: DRAFT: Experimentally remove unidecode

Posted by GitBox <gi...@apache.org>.

ryw closed pull request #10665:
URL: https://github.com/apache/airflow/pull/10665


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #10665: DRAFT: Experimentally remove unidecode

Posted by GitBox <gi...@apache.org>.

potiuk commented on pull request #10665:
URL: https://github.com/apache/airflow/pull/10665#issuecomment-684004562


   The PR is coming as you speak. BTW. See the https://github.com/apache/airflow/blob/master/requirements/REMOVE.md  note that I left before.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #10665: DRAFT: Experimentally remove unidecode

Posted by GitBox <gi...@apache.org>.

potiuk commented on pull request #10665:
URL: https://github.com/apache/airflow/pull/10665#issuecomment-684008648

BTW. The vulnerability scanner will likely still show those dependencies, if it is actually working (I would love to hear if it does).

As explained, the dependencies in our project come from setup.py and unidecode is a transitive dependency (nothing changes by removing this file). So if it will stop unidecode as dependency, it means that it does not detect the "proper" ones..

More about it here: https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pinned-constraint-files

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #10665: DRAFT: Experimentally remove unidecode

Posted by GitBox <gi...@apache.org>.

potiuk commented on pull request #10665:
URL: https://github.com/apache/airflow/pull/10665#issuecomment-684010452


   PR here: https://github.com/apache/airflow/pull/10668


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org