[GitHub] [incubator-druid] gianm commented on a change in pull request #7224: Add ROUND function in druid-sql.

[GitBox <gi...@apache.org>]

gianm commented on a change in pull request #7224: Add ROUND function in druid-sql.
URL: https://github.com/apache/incubator-druid/pull/7224#discussion_r275166846
 
 

 ##########
 File path: docs/content/misc/math-expr.md
 ##########
 @@ -133,7 +133,7 @@ See javadoc of java.lang.Math for detailed explanation for each function.
 |pow|pow(x, y) would return the value of the x raised to the power of y|
 |remainder|remainder(x, y) would return the remainder operation on two arguments as prescribed by the IEEE 754 standard|
 |rint|rint(x) would return value that is closest in value to x and is equal to a mathematical integer|
-|round|round(x) would return the closest long value to x, with ties rounding up|
+|round|round(x, y) would return the value of the x rounded to the y decimal places. While x can be an integer or floating-point number, y must be an integer. The type of the return value is specified by that of x. y defaults to 0 if omitted. When y is negative, x is rounded on the left side of the y decimal points.|
 
 Review comment:
   Please add this to the SQL docs too (querying/sql.md)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org