You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by "jnturton (via GitHub)" <gi...@apache.org> on 2023/08/24 12:52:51 UTC
[PR] DRILL-8454: Disable unsupported MapR profile and plugin (drill)
jnturton opened a new pull request, #2825:
URL: https://github.com/apache/drill/pull/2825
# [DRILL-8454](https://issues.apache.org/jira/browse/DRILL-8454): Disable unsupported MapR profile and plugin
## Description
The MapR build profile and format plugin, which fell out of support in the open source Drill codebase years ago, are disabled. Drill users needing support for these components should contact HPE.
## Documentation
See the HPE Ezmeral docs.
## Testing
Build and unit tests of remaining modules pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8454: Disable unsupported MapR profile and plugin (drill)
Posted by "rymarm (via GitHub)" <gi...@apache.org>.
rymarm commented on PR #2825:
URL: https://github.com/apache/drill/pull/2825#issuecomment-1705236361
@jnturton Hi! I'll take a look at this pull request this week later or even next week. I've just got back from a vacation and got on a "burning boat" of work)
But I have a question now, Why did you decide to comment the mapr specific changes, but not completely remove them?
And in addition, I suppose that we also need to remove mentions of maprdb support from the [documentation](https://drill.apache.org/docs/mapr-db-format/) or leave a link to HPE documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8454: Disable unsupported MapR profile and plugin (drill)
Posted by "jnturton (via GitHub)" <gi...@apache.org>.
jnturton merged PR #2825:
URL: https://github.com/apache/drill/pull/2825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8454: Disable unsupported MapR profile and plugin (drill)
Posted by "cgivre (via GitHub)" <gi...@apache.org>.
cgivre commented on PR #2825:
URL: https://github.com/apache/drill/pull/2825#issuecomment-1759632305
@jnturton Can we merge this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8454: Disable unsupported MapR profile and plugin (drill)
Posted by "jnturton (via GitHub)" <gi...@apache.org>.
jnturton commented on PR #2825:
URL: https://github.com/apache/drill/pull/2825#issuecomment-1760767117
@cgivre let me convert the comment blocks to deletions as suggested by you and @rymarm and then let's merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8454: Disable unsupported MapR profile and plugin (drill)
Posted by "jnturton (via GitHub)" <gi...@apache.org>.
jnturton commented on PR #2825:
URL: https://github.com/apache/drill/pull/2825#issuecomment-1693009858
This one's ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8454: Disable unsupported MapR profile and plugin (drill)
Posted by "jnturton (via GitHub)" <gi...@apache.org>.
jnturton commented on PR #2825:
URL: https://github.com/apache/drill/pull/2825#issuecomment-1772514807
> @cgivre let me convert the comment blocks to deletions as suggested by you and @rymarm and then let's merge it.
Done...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8454: Disable unsupported MapR profile and plugin (drill)
Posted by "jnturton (via GitHub)" <gi...@apache.org>.
jnturton commented on PR #2825:
URL: https://github.com/apache/drill/pull/2825#issuecomment-1705270050
@rymarm welcome back! I wasn't sure whether to delete or comment out the mapr modules. I decided to try moving them to new, commented out sections of "Objects of type foo that are no longer supported" that seemed to keep an informative history in the source files without a lot of extra cruft. But that history is always available in Git so I'm also happy to delete instead...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8454: Disable unsupported MapR profile and plugin (drill)
Posted by "jnturton (via GitHub)" <gi...@apache.org>.
jnturton commented on PR #2825:
URL: https://github.com/apache/drill/pull/2825#issuecomment-1695823466
A note to the reviewers. Git's default diff algorithm makes it very hard to see that the changes this PR makes to pom.xml are simply whole sections moving into comment blocks. GitHub does not allow selection diff algorithm at this time so, to ease review, I have therefore [uploaded the diff of pom.xml generated using `git diff --diff-algorithm=patience` separately](https://gist.github.com/jnturton/f7a623046da2861bad93419529ff78b3). It is of course also possible to run this locally after pulling down my branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org