You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by andrei-ivanov <gi...@git.apache.org> on 2018/09/16 13:46:50 UTC

[GitHub] logging-log4j-audit pull request #4: [LOG4J2-2443]

GitHub user andrei-ivanov opened a pull request:

    https://github.com/apache/logging-log4j-audit/pull/4

    [LOG4J2-2443]

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/andrei-ivanov/logging-log4j-audit LOG4J2-2443

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/logging-log4j-audit/pull/4.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4
    
----
commit 5c5c875d324898ea51d9a1797a34bf60e62c517c
Author: Andrei Ivanov <an...@...>
Date:   2018-09-16T13:03:32Z

    [LOG4J2-2443] Remove unused exceptions

commit a27bd7642be15b41bbc5d63ddf17257f982623f3
Author: Andrei Ivanov <an...@...>
Date:   2018-09-16T13:14:40Z

    [LOG4J2-2443] optimize imports

commit b3f088ef893921ffa42a2c9a6e6559a4cd3569cd
Author: Andrei Ivanov <an...@...>
Date:   2018-09-16T13:14:49Z

    [LOG4J2-2443] Remove unused exception

commit 13f058151de0f6a45136073f347750c177cbbf54
Author: Andrei Ivanov <an...@...>
Date:   2018-09-16T13:17:31Z

    [LOG4J2-2443] Remove unused exception, seems to be a duplicate of CatalogModificationException

commit bf545f37122cd080d17278f8516e2091a04c75fa
Author: Andrei Ivanov <an...@...>
Date:   2018-09-16T13:31:09Z

    [LOG4J2-2443] Consistent throwning of ConstraintValidationException for valitation errors

commit 063c2580fac4975b3dc47c2a32a6763ae9379cc2
Author: Andrei Ivanov <an...@...>
Date:   2018-09-16T13:44:05Z

    [LOG4J2-2443] move ConstraintValidationException in the log4j-audit-api module as it's the only place it was used and make it extend AuditException

----


---

[GitHub] logging-log4j-audit issue #4: [LOG4J2-2443]

Posted by andrei-ivanov <gi...@git.apache.org>.

Github user andrei-ivanov commented on the issue:

    https://github.com/apache/logging-log4j-audit/pull/4
  
    If/when #8 also gets merged, I'll take care of the modifications for this one.


---

[GitHub] logging-log4j-audit issue #4: [LOG4J2-2443]

Posted by rgoers <gi...@git.apache.org>.

Github user rgoers commented on the issue:

    https://github.com/apache/logging-log4j-audit/pull/4
  
    This PR has merge conflicts.


---

[GitHub] logging-log4j-audit issue #4: [LOG4J2-2443]

Posted by andrei-ivanov <gi...@git.apache.org>.

Github user andrei-ivanov commented on the issue:

    https://github.com/apache/logging-log4j-audit/pull/4
  
    I should have left this one for later, as it actually depends on the other ones :)


---

[GitHub] logging-log4j-audit pull request #4: [LOG4J2-2443]

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/logging-log4j-audit/pull/4


---

[GitHub] logging-log4j-audit issue #4: [LOG4J2-2443]

Posted by andrei-ivanov <gi...@git.apache.org>.

Github user andrei-ivanov commented on the issue:

    https://github.com/apache/logging-log4j-audit/pull/4
  
    Conflicts resolved.
    
    ⚠Btw, not sure if it matters for semantic versioning, but this PR deletes some classes, the unused exceptions.


---