You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by kxepal <gi...@git.apache.org> on 2015/09/17 22:12:23 UTC
[GitHub] couchdb-chttpd pull request: Use illegal_docid error for really ba...
GitHub user kxepal opened a pull request:
https://github.com/apache/couchdb-chttpd/pull/74
Use illegal_docid error for really bad document ids
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kxepal/couchdb-chttpd use-illegal-docid-error
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-chttpd/pull/74.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #74
----
commit 0d1d6c9fecfa526eccc1da176b2df40dd538dd20
Author: Alexander Shorin <kx...@apache.org>
Date: 2015-09-17T20:09:45Z
Use illegal_docid error for really bad document ids
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-chttpd pull request: Use illegal_docid error for really ba...
Posted by tonysun83 <gi...@git.apache.org>.
Github user tonysun83 commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/74#issuecomment-141368472
ah, from the other PR you referenced above. I see it now.
+1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-chttpd pull request: Use illegal_docid error for really ba...
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/74#issuecomment-142390309
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-chttpd pull request: Use illegal_docid error for really ba...
Posted by tonysun83 <gi...@git.apache.org>.
Github user tonysun83 commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/74#issuecomment-141227359
just curious why we're adding an extra match here in addition to this change:
https://github.com/apache/couchdb-chttpd/pull/73/files
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-chttpd pull request: Use illegal_docid error for really ba...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-chttpd/pull/74
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-chttpd pull request: Use illegal_docid error for really ba...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/74#issuecomment-141213282
See also: https://github.com/apache/couchdb-couch/pull/101
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-chttpd pull request: Use illegal_docid error for really ba...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/74#issuecomment-141234916
@tonysun83
First match `{illegal_docid, Reason}` is for direct `couch_doc:validate_docid/1` call.
Second match goes for all_docs view and caused by some fabric internals. I didn't found where and why it's so awkward.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---