You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/11/05 02:14:40 UTC

[GitHub] [iotdb] cornmonster commented on a change in pull request #4303: [IOTDB-1760] Support other aggregations in group by fill

cornmonster commented on a change in pull request #4303:
URL: https://github.com/apache/iotdb/pull/4303#discussion_r743346455



##########
File path: server/src/main/java/org/apache/iotdb/db/query/executor/fill/LinearFill.java
##########
@@ -65,6 +68,30 @@ public LinearFill(TSDataType dataType, long queryTime, long beforeRange, long af
     this.afterRange = afterRange;
   }
 
+  public LinearFill() {}
+
+  public void convertRange(long startTime, long endTime) {
+    if (beforeRange % GroupByEngineDataSet.MS_TO_MONTH == 0) {
+      Calendar calendar = Calendar.getInstance();

Review comment:
       Please use the new date and time API defined in java8. See org.apache.iotdb.db.qp.utils.DatetimeUtils for examples.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org