You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/08/15 19:11:00 UTC

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15358: Numpy hsplit

haojin2 commented on a change in pull request #15358: Numpy hsplit
URL: https://github.com/apache/incubator-mxnet/pull/15358#discussion_r314456576
 
 

 ##########
 File path: src/operator/numpy/np_matrix_op-inl.h
 ##########
 @@ -59,6 +59,222 @@ void NumpyTranspose(const nnvm::NodeAttrs& attrs,
   }
 }
 
 
 Review comment:
   Seems like you're re-using most of the existing [SplitOpForward](https://github.com/apache/incubator-mxnet/blob/master/src/operator/tensor/matrix_op-inl.h#L2762-L2823) and [SplitOpBackward](https://github.com/apache/incubator-mxnet/blob/master/src/operator/tensor/matrix_op-inl.h#L2825-L2887), maybe you could refactor the existing code to expose common SplitOpForwardImpl and SplitOpBackwardImpl and call these functions from here instead of copying the code over.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services