You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Alessandro Bologna (JIRA)" <ji...@apache.org> on 2007/06/13 15:49:26 UTC

[jira] Created: (JCR-971) DocumentViewExportVisitor class incorrectly handles XML escaping for element names

DocumentViewExportVisitor class incorrectly handles XML escaping for element names
----------------------------------------------------------------------------------

                 Key: JCR-971
                 URL: https://issues.apache.org/jira/browse/JCR-971
             Project: Jackrabbit
          Issue Type: Bug
          Components: contrib PMs
    Affects Versions: 1.3
            Reporter: Alessandro Bologna
            Priority: Trivial


The method private static String escapeName(String name) should have the following test:

 if ((i == 0) ? XMLChar.isNCNameStart(ch) : XMLChar.isNCName(ch)) {

changed into

 if ((i == 0) ? !XMLChar.isNCNameStart(ch) :! XMLChar.isNCName(ch)) {

in order to properly escape the text (those two methods in XMLChar return true when the character is valid, not the other way around.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (JCR-971) DocumentViewExportVisitor class incorrectly handles XML escaping for element names

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting reassigned JCR-971:
---------------------------------

    Assignee: Jukka Zitting

> DocumentViewExportVisitor class incorrectly handles XML escaping for element names
> ----------------------------------------------------------------------------------
>
>                 Key: JCR-971
>                 URL: https://issues.apache.org/jira/browse/JCR-971
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: contrib PMs
>    Affects Versions: 1.3
>            Reporter: Alessandro Bologna
>            Assignee: Jukka Zitting
>            Priority: Trivial
>
> The method private static String escapeName(String name) should have the following test:
>  if ((i == 0) ? XMLChar.isNCNameStart(ch) : XMLChar.isNCName(ch)) {
> changed into
>  if ((i == 0) ? !XMLChar.isNCNameStart(ch) :! XMLChar.isNCName(ch)) {
> in order to properly escape the text (those two methods in XMLChar return true when the character is valid, not the other way around.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (JCR-971) DocumentViewExportVisitor class incorrectly handles XML escaping for element names

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting resolved JCR-971.
-------------------------------

    Resolution: Fixed

Fix applied in revision 558164. Thanks!

> DocumentViewExportVisitor class incorrectly handles XML escaping for element names
> ----------------------------------------------------------------------------------
>
>                 Key: JCR-971
>                 URL: https://issues.apache.org/jira/browse/JCR-971
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: contrib PMs
>    Affects Versions: 1.3
>            Reporter: Alessandro Bologna
>            Assignee: Jukka Zitting
>            Priority: Trivial
>
> The method private static String escapeName(String name) should have the following test:
>  if ((i == 0) ? XMLChar.isNCNameStart(ch) : XMLChar.isNCName(ch)) {
> changed into
>  if ((i == 0) ? !XMLChar.isNCNameStart(ch) :! XMLChar.isNCName(ch)) {
> in order to properly escape the text (those two methods in XMLChar return true when the character is valid, not the other way around.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.