You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Zhen Zhang <ne...@gmail.com> on 2013/07/31 22:17:01 UTC
Review Request 13090: HELIX-155: PropertyKey.instances() is wrongly wired to
CONFIG type instead of INSTANCES type
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13090/
-----------------------------------------------------------
Review request for helix, Kanak Biscuitwala, Kishore Gopalakrishna, and Shi Lu.
Repository: helix-git
Description
-------
HELIX-155: PropertyKey#instances() is wrongly wired to CONFIG type instead of INSTANCES type:
public PropertyKey instances()
{
return new PropertyKey(CONFIGS, null, _clusterName);
}
Diffs
-----
helix-core/src/main/java/org/apache/helix/PropertyKey.java 80aeaf1
Diff: https://reviews.apache.org/r/13090/diff/
Testing
-------
Thanks,
Zhen Zhang
Re: Review Request 13090: HELIX-155: PropertyKey.instances() is wrongly
wired to CONFIG type instead of INSTANCES type
Posted by Kanak Biscuitwala <ka...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13090/#review24369
-----------------------------------------------------------
Looks good to me. There's a lot of existing stray trailing spaces in the file, but that's probably best for a separate task.
- Kanak Biscuitwala
On July 31, 2013, 8:17 p.m., Zhen Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13090/
> -----------------------------------------------------------
>
> (Updated July 31, 2013, 8:17 p.m.)
>
>
> Review request for helix, Kanak Biscuitwala, Kishore Gopalakrishna, and Shi Lu.
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> HELIX-155: PropertyKey#instances() is wrongly wired to CONFIG type instead of INSTANCES type:
>
>
> public PropertyKey instances()
> {
> return new PropertyKey(CONFIGS, null, _clusterName);
> }
>
>
> Diffs
> -----
>
> helix-core/src/main/java/org/apache/helix/PropertyKey.java 80aeaf1
>
> Diff: https://reviews.apache.org/r/13090/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhen Zhang
>
>
Re: Review Request 13090: HELIX-155: PropertyKey.instances() is wrongly
wired to CONFIG type instead of INSTANCES type
Posted by Kishore Gopalakrishna <ki...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13090/#review24373
-----------------------------------------------------------
Ship it!
Ship It!
- Kishore Gopalakrishna
On July 31, 2013, 8:17 p.m., Zhen Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13090/
> -----------------------------------------------------------
>
> (Updated July 31, 2013, 8:17 p.m.)
>
>
> Review request for helix, Kanak Biscuitwala, Kishore Gopalakrishna, and Shi Lu.
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> HELIX-155: PropertyKey#instances() is wrongly wired to CONFIG type instead of INSTANCES type:
>
>
> public PropertyKey instances()
> {
> return new PropertyKey(CONFIGS, null, _clusterName);
> }
>
>
> Diffs
> -----
>
> helix-core/src/main/java/org/apache/helix/PropertyKey.java 80aeaf1
>
> Diff: https://reviews.apache.org/r/13090/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhen Zhang
>
>