[Bug 57578] New: HTTPRequest : When md5 is checked Embedded Resources from HTML files should be disabled

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=57578

            Bug ID: 57578
           Summary: HTTPRequest : When md5 is checked Embedded Resources
                    from HTML files should be disabled
           Product: JMeter
           Version: 2.12
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: HTTP
          Assignee: issues@jmeter.apache.org
          Reporter: p.mouawad@ubik-ingenierie.com

When MD5 is checked as response is not stored, no parsing can occur.
So checking anything in "Embedded Resources from HTML files" panel won't have
any effect.
I suggest we disable checkbox "Retrieve All embedded resources" when "Save
response as MD5 Hash" is checked.

By the way, it seems HttpTestSampleGui uselessly implemented ItemListener as
none of the addItemListeners in classes uses it. So I suggest we drop it adding
this to "Incompatible changes" as subclasses may be impacted.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 57578] HTTPRequest : When md5 is checked Embedded Resources from HTML files should be disabled

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=57578

--- Comment #1 from Sebb <se...@apache.org> ---
(In reply to Philippe Mouawad from comment #0)
> When MD5 is checked as response is not stored, no parsing can occur.

It could occur, but does not currently.

> So checking anything in "Embedded Resources from HTML files" panel won't
> have any effect.
> I suggest we disable checkbox "Retrieve All embedded resources" when "Save
> response as MD5 Hash" is checked.

If the user decides they then want to retrieve the embedded resources, won't
this make it rather awkward for the user? They will have to disable Md5 first.
And why should MD5 disable embedded but not the other way round?

I think it would be better to just make a note in the manual.

It might be OK to deselect embedded (rather than disabling it) when selecting
MD5 -- and vice versa.

Alternatively, maybe the code _should_ still parse the responses, but replace
the sample data with the MD5 when it is no longer needed. This will require
more storage whilst the sample is being processed. The code should only store
the full response if it needs to be parsed - i.e. images etc. would be
converted to MD5 directly. It might be possible to parse the response as it is
read, rather than waiting for it to be fully loaded first.

However, this would change the test plan behaviour. There would need to be some
way to disable it.

> By the way, it seems HttpTestSampleGui uselessly implemented ItemListener as
> none of the addItemListeners in classes uses it. So I suggest we drop it
> adding this to "Incompatible changes" as subclasses may be impacted.

That belongs in a separate Bugzilla issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.