[jira] [Commented] (HBASE-25073) Should not use XXXService.Interface.class.getSimpleName as stub key prefix in AsyncConnectionImpl

["Duo Zhang (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-25073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17198989#comment-17198989 ] 

Duo Zhang commented on HBASE-25073:
-----------------------------------

For me I think XXXService.getDescriptor().getName() is better.

> Should not use XXXService.Interface.class.getSimpleName as stub key prefix in AsyncConnectionImpl
> -------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-25073
>                 URL: https://issues.apache.org/jira/browse/HBASE-25073
>             Project: HBase
>          Issue Type: Task
>          Components: Client
>            Reporter: Duo Zhang
>            Priority: Major
>              Labels: beginner, trivial
>
> It will just return "Interface" for all services. This is not a bug for AsyncConnectionImpl as we have different maps for ClientService and AdminService, but it is still a bit confusing to developers.
> I suggest either we just use empty string and add a comment to say that the service name is not important here, or change to use XXXService.class.getSimpleName() or XXXService.getDescriptor().getName(), so it is less confusing to developers.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)