You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/06/20 12:45:33 UTC
[GitHub] [maven-dependency-analyzer] elharo opened a new pull request #37: [MDEP-753] test to demonstrate failure
elharo opened a new pull request #37:
URL: https://github.com/apache/maven-dependency-analyzer/pull/37
test that fails
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-analyzer] mirabilos commented on a change in pull request #37: [MDEP-753] handle different classes from same artifact used by model and test code
Posted by GitBox <gi...@apache.org>.
mirabilos commented on a change in pull request #37:
URL: https://github.com/apache/maven-dependency-analyzer/pull/37#discussion_r800934678
##########
File path: src/test/resources/jarWithCompileDependency/project2/pom.xml
##########
@@ -36,6 +36,11 @@
<artifactId>jarWithCompileDependency1</artifactId>
<version>1.0</version>
</dependency>
+ <dependency>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
+ <version>30.1.1-android</version>
Review comment:
Why `-android` and not `-jre` (which seems to be more suitable)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-analyzer] elharo merged pull request #37: [MDEP-753] handle different classes from same artifact used by model and test code
Posted by GitBox <gi...@apache.org>.
elharo merged pull request #37:
URL: https://github.com/apache/maven-dependency-analyzer/pull/37
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-analyzer] mirabilos commented on a change in pull request #37: [MDEP-753] handle different classes from same artifact used by model and test code
Posted by GitBox <gi...@apache.org>.
mirabilos commented on a change in pull request #37:
URL: https://github.com/apache/maven-dependency-analyzer/pull/37#discussion_r800960181
##########
File path: src/test/resources/jarWithCompileDependency/project2/pom.xml
##########
@@ -36,6 +36,11 @@
<artifactId>jarWithCompileDependency1</artifactId>
<version>1.0</version>
</dependency>
+ <dependency>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
+ <version>30.1.1-android</version>
Review comment:
Oh right, good point. I *did* just see a `-android` guava dependency in a Maven plugin (on mvnrepository.com), that’s why…
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-analyzer] elharo commented on a change in pull request #37: [MDEP-753] handle different classes from same artifact used by model and test code
Posted by GitBox <gi...@apache.org>.
elharo commented on a change in pull request #37:
URL: https://github.com/apache/maven-dependency-analyzer/pull/37#discussion_r800948257
##########
File path: src/test/resources/jarWithCompileDependency/project2/pom.xml
##########
@@ -36,6 +36,11 @@
<artifactId>jarWithCompileDependency1</artifactId>
<version>1.0</version>
</dependency>
+ <dependency>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
+ <version>30.1.1-android</version>
Review comment:
This is a test. This is only a test. had this been a real dependency you'd get a different answer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org