You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "caldempsey (via GitHub)" <gi...@apache.org> on 2025/09/03 18:09:21 UTC

Re: [PR] [SPARK-52780] Add ToLocalIterator and Arrow Record Streaming [spark-connect-go]

caldempsey commented on code in PR #152:
URL: https://github.com/apache/spark-connect-go/pull/152#discussion_r2319804696


##########
spark/sql/dataframe.go:
##########
@@ -213,6 +213,7 @@ type DataFrame interface {
 	Take(ctx context.Context, limit int32) ([]types.Row, error)
 	// ToArrow returns the Arrow representation of the DataFrame.
 	ToArrow(ctx context.Context) (*arrow.Table, error)
+	ToLocalIterator(ctx context.Context) (types.RowIterator, error)

Review Comment:
   Updated to use Seq2, seemed to better match the Iterator semantics we wanted to expose



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org