[GitHub] [hudi] yihua commented on a diff in pull request #8155: [HUDI-5781] Refactor other classes to use HoodieConfig/ConfigProperty

["yihua (via GitHub)" <gi...@apache.org>]

yihua commented on code in PR #8155:
URL: https://github.com/apache/hudi/pull/8155#discussion_r1133461106


##########
hudi-common/src/main/java/org/apache/hudi/common/config/ConfigGroups.java:
##########
@@ -37,7 +37,8 @@ public enum Names {
     METRICS("Metrics Configs"),
     RECORD_PAYLOAD("Record Payload Config"),
     KAFKA_CONNECT("Kafka Connect Configs"),
-    AWS("Amazon Web Services Configs");
+    AWS("Amazon Web Services Configs"),
+    DELTA_STREAMER("DeltaStreamer Configs");

Review Comment:
   Remove the change from #8152?



##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/config/HoodieDeltaStreamerConfig.java:
##########
@@ -93,6 +93,16 @@ public class HoodieDeltaStreamerConfig extends HoodieConfig {
       .withDocumentation("The path to which a particular table is ingested. The config is specific to HoodieMultiTableDeltaStreamer"
           + " and overrides path determined using option `--base-path-prefix` for a table");
 
+  public static final ConfigProperty<String> TRANSFORMER_SQL_FILE = ConfigProperty

Review Comment:
   Let's add transformer configs into a separate config class `DeltaStreamerTransformerConfig`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org