You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Till Toenshoff <to...@me.com> on 2014/03/04 03:24:47 UTC
Review Request 18723: Prevent gflags detection from glog configuration phase
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18723/
-----------------------------------------------------------
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Niklas Nielsen, and Vinod Kone.
Bugs: MESOS-1010
https://issues.apache.org/jira/browse/MESOS-1010
Repository: mesos-git
Description
-------
Removes the gflags detection from the glog configuration phase.
Patched both, configure.ac as well as configure to prevent us from having to run autoreconf on this bundle by default.
Diffs
-----
3rdparty/libprocess/3rdparty/glog-0.3.3.patch 76b8c0f
Diff: https://reviews.apache.org/r/18723/diff/
Testing
-------
make check (while having gflags previously installed).
Thanks,
Till Toenshoff
Re: Review Request 18723: Prevent gflags detection from glog
configuration phase
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18723/
-----------------------------------------------------------
(Updated Aug. 14, 2015, 10:34 a.m.)
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-1010
https://issues.apache.org/jira/browse/MESOS-1010
Repository: mesos
Description (updated)
-------
Removes the gflags detection from the glog configuration phase.
Patched both, configure.ac as well as configure to prevent us from having to run autoreconf on this bundle by default.
NOTE: Do NOT commit - this is an ancient patch meant to illustrate a problem with a trivial fix - a proper fix is in the works by Greg Mann.
Diffs
-----
3rdparty/libprocess/3rdparty/glog-0.3.3.patch 76b8c0f
Diff: https://reviews.apache.org/r/18723/diff/
Testing
-------
make check (while having gflags previously installed).
Thanks,
Till Toenshoff
Re: Review Request 18723: Prevent gflags detection from glog
configuration phase
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18723/
-----------------------------------------------------------
(Updated Aug. 12, 2015, 2:50 p.m.)
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-1010
https://issues.apache.org/jira/browse/MESOS-1010
Repository: mesos
Description
-------
Removes the gflags detection from the glog configuration phase.
Patched both, configure.ac as well as configure to prevent us from having to run autoreconf on this bundle by default.
Diffs
-----
3rdparty/libprocess/3rdparty/glog-0.3.3.patch 76b8c0f
Diff: https://reviews.apache.org/r/18723/diff/
Testing
-------
make check (while having gflags previously installed).
Thanks,
Till Toenshoff
Re: Review Request 18723: Prevent gflags detection from glog
configuration phase
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18723/#review94266
-----------------------------------------------------------
Ship it!
Ship It!
- haosdent huang
On March 6, 2014, 6:48 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18723/
> -----------------------------------------------------------
>
> (Updated March 6, 2014, 6:48 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-1010
> https://issues.apache.org/jira/browse/MESOS-1010
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removes the gflags detection from the glog configuration phase.
>
> Patched both, configure.ac as well as configure to prevent us from having to run autoreconf on this bundle by default.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/glog-0.3.3.patch 76b8c0f
>
> Diff: https://reviews.apache.org/r/18723/diff/
>
>
> Testing
> -------
>
> make check (while having gflags previously installed).
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 18723: Prevent gflags detection from glog configuration
phase
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18723/#review36506
-----------------------------------------------------------
Patch looks great!
Reviews applied: [18723]
All tests passed.
- Mesos ReviewBot
On March 6, 2014, 6:48 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18723/
> -----------------------------------------------------------
>
> (Updated March 6, 2014, 6:48 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-1010
> https://issues.apache.org/jira/browse/MESOS-1010
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Removes the gflags detection from the glog configuration phase.
>
> Patched both, configure.ac as well as configure to prevent us from having to run autoreconf on this bundle by default.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/glog-0.3.3.patch 76b8c0f
>
> Diff: https://reviews.apache.org/r/18723/diff/
>
>
> Testing
> -------
>
> make check (while having gflags previously installed).
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 18723: Prevent gflags detection from glog configuration
phase
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18723/
-----------------------------------------------------------
(Updated March 6, 2014, 6:48 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
assigning to @benjaminhindman for review.
Bugs: MESOS-1010
https://issues.apache.org/jira/browse/MESOS-1010
Repository: mesos-git
Description
-------
Removes the gflags detection from the glog configuration phase.
Patched both, configure.ac as well as configure to prevent us from having to run autoreconf on this bundle by default.
Diffs
-----
3rdparty/libprocess/3rdparty/glog-0.3.3.patch 76b8c0f
Diff: https://reviews.apache.org/r/18723/diff/
Testing
-------
make check (while having gflags previously installed).
Thanks,
Till Toenshoff