You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/15 09:12:23 UTC

[GitHub] [incubator-superset] dpgaspar opened a new pull request #12056: fix(reports): increase crontab size

dpgaspar opened a new pull request #12056:
URL: https://github.com/apache/incubator-superset/pull/12056


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] dpgaspar merged pull request #12056: fix(reports): increase crontab size and alert fixes

Posted by GitBox <gi...@apache.org>.
dpgaspar merged pull request #12056:
URL: https://github.com/apache/incubator-superset/pull/12056


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12056: fix(reports): increase crontab size and alert fixes

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12056:
URL: https://github.com/apache/incubator-superset/pull/12056#issuecomment-745501290


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=h1) Report
   > Merging [#12056](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=desc) (1a7fc55) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9c8b65d03fd7676f2600be89d19000b9756b4e2c?el=desc) (9c8b65d) will **decrease** coverage by `0.11%`.
   > The diff coverage is `12.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12056/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12056      +/-   ##
   ==========================================
   - Coverage   63.72%   63.60%   -0.12%     
   ==========================================
     Files         958      959       +1     
     Lines       47103    47117      +14     
     Branches     4609     4609              
   ==========================================
   - Hits        30016    29971      -45     
   - Misses      16903    16962      +59     
     Partials      184      184              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `62.66% <ø> (ø)` | |
   | python | `64.18% <12.50%> (-0.19%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ersions/ab104a954a8f\_reports\_alter\_crontab\_size.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hYjEwNGE5NTRhOGZfcmVwb3J0c19hbHRlcl9jcm9udGFiX3NpemUucHk=) | `0.00% <0.00%> (ø)` | |
   | [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.48% <ø> (ø)` | |
   | [superset/tasks/scheduler.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.81% <0.00%> (-8.59%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.61% <0.00%> (-0.28%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.37% <0.00%> (-0.14%)` | :arrow_down: |
   | ... and [1 more](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=footer). Last update [9c8b65d...bb2a411](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12056: fix(reports): increase crontab size

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12056:
URL: https://github.com/apache/incubator-superset/pull/12056#issuecomment-745501290


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=h1) Report
   > Merging [#12056](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=desc) (d716bd0) into [master](https://codecov.io/gh/apache/incubator-superset/commit/832267c77650fad8a1f69666900ea37a2006ad5c?el=desc) (832267c) will **decrease** coverage by `0.39%`.
   > The diff coverage is `14.28%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12056/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12056      +/-   ##
   ==========================================
   - Coverage   63.81%   63.42%   -0.40%     
   ==========================================
     Files         954      957       +3     
     Lines       46774    46857      +83     
     Branches     4589     4590       +1     
   ==========================================
   - Hits        29849    29718     -131     
   - Misses      16741    16955     +214     
     Partials      184      184              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `62.67% <ø> (-0.05%)` | :arrow_down: |
   | python | `63.87% <14.28%> (-0.61%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ersions/ab104a954a8f\_reports\_alter\_crontab\_size.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hYjEwNGE5NTRhOGZfcmVwb3J0c19hbHRlcl9jcm9udGFiX3NpemUucHk=) | `0.00% <0.00%> (ø)` | |
   | [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.48% <ø> (ø)` | |
   | [superset/tasks/scheduler.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.47% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
   | [...perset-frontend/src/views/CRUD/alert/AlertList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvQWxlcnRMaXN0LnRzeA==) | `63.95% <0.00%> (-12.80%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-3.87%)` | :arrow_down: |
   | ... and [17 more](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=footer). Last update [832267c...d716bd0](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] dpgaspar removed a comment on pull request #12056: fix(reports): increase crontab size

Posted by GitBox <gi...@apache.org>.
dpgaspar removed a comment on pull request #12056:
URL: https://github.com/apache/incubator-superset/pull/12056#issuecomment-745192658


   when CI finishes
   ![](https://giphy.com/gifs/pGkwaGc54Byx2/html5)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12056: fix(reports): increase crontab size and alert fixes

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12056:
URL: https://github.com/apache/incubator-superset/pull/12056#issuecomment-745501290


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=h1) Report
   > Merging [#12056](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=desc) (1a7fc55) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9c8b65d03fd7676f2600be89d19000b9756b4e2c?el=desc) (9c8b65d) will **decrease** coverage by `0.31%`.
   > The diff coverage is `12.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12056/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12056      +/-   ##
   ==========================================
   - Coverage   63.72%   63.40%   -0.32%     
   ==========================================
     Files         958      476     -482     
     Lines       47103    29348   -17755     
     Branches     4609        0    -4609     
   ==========================================
   - Hits        30016    18609   -11407     
   + Misses      16903    10739    -6164     
   + Partials      184        0     -184     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `?` | |
   | python | `63.40% <12.50%> (-0.96%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ersions/ab104a954a8f\_reports\_alter\_crontab\_size.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hYjEwNGE5NTRhOGZfcmVwb3J0c19hbHRlcl9jcm9udGFiX3NpemUucHk=) | `0.00% <0.00%> (ø)` | |
   | [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.48% <ø> (ø)` | |
   | [superset/tasks/scheduler.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
   | [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
   | ... and [510 more](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=footer). Last update [9c8b65d...bb2a411](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] dpgaspar edited a comment on pull request #12056: fix(reports): increase crontab size

Posted by GitBox <gi...@apache.org>.
dpgaspar edited a comment on pull request #12056:
URL: https://github.com/apache/incubator-superset/pull/12056#issuecomment-745192658


   when CI finishes
   ![](https://media.giphy.com/media/pGkwaGc54Byx2/giphy.gif)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12056: fix(reports): increase crontab size and alert fixes

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12056:
URL: https://github.com/apache/incubator-superset/pull/12056#issuecomment-745501290


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=h1) Report
   > Merging [#12056](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=desc) (153e113) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9c8b65d03fd7676f2600be89d19000b9756b4e2c?el=desc) (9c8b65d) will **decrease** coverage by `1.06%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12056/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12056      +/-   ##
   ==========================================
   - Coverage   63.72%   62.66%   -1.07%     
   ==========================================
     Files         958      483     -475     
     Lines       47103    17754   -29349     
     Branches     4609     4609              
   ==========================================
   - Hits        30016    11125   -18891     
   + Misses      16903     6445   -10458     
     Partials      184      184              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `62.66% <ø> (ø)` | |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...erset/migrations/versions/430039611635\_log\_more.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy80MzAwMzk2MTE2MzVfbG9nX21vcmUucHk=) | | |
   | [superset/migrations/versions/30bb17c0dc76\_.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8zMGJiMTdjMGRjNzZfLnB5) | | |
   | [.../migrations/versions/2fcdcb35e487\_saved\_queries.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8yZmNkY2IzNWU0ODdfc2F2ZWRfcXVlcmllcy5weQ==) | | |
   | [superset/translations/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdHJhbnNsYXRpb25zL3V0aWxzLnB5) | | |
   | [superset/db\_engine\_specs/elasticsearch.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2VsYXN0aWNzZWFyY2gucHk=) | | |
   | [superset/annotation\_layers/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | | |
   | [superset/commands/importers/v1/examples.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL2V4YW1wbGVzLnB5) | | |
   | [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | | |
   | [superset/examples/countries.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvY291bnRyaWVzLnB5) | | |
   | [...perset/migrations/versions/2591d77e9831\_user\_id.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8yNTkxZDc3ZTk4MzFfdXNlcl9pZC5weQ==) | | |
   | ... and [461 more](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=footer). Last update [9c8b65d...bb2a411](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12056: fix(reports): increase crontab size and alert fixes

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12056:
URL: https://github.com/apache/incubator-superset/pull/12056#issuecomment-745501290


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=h1) Report
   > Merging [#12056](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=desc) (1a7fc55) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9c8b65d03fd7676f2600be89d19000b9756b4e2c?el=desc) (9c8b65d) will **decrease** coverage by `0.40%`.
   > The diff coverage is `12.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12056/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12056      +/-   ##
   ==========================================
   - Coverage   63.72%   63.31%   -0.41%     
   ==========================================
     Files         958      959       +1     
     Lines       47103    47117      +14     
     Branches     4609     4609              
   ==========================================
   - Hits        30016    29833     -183     
   - Misses      16903    17100     +197     
     Partials      184      184              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `62.66% <ø> (ø)` | |
   | python | `63.71% <12.50%> (-0.66%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ersions/ab104a954a8f\_reports\_alter\_crontab\_size.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hYjEwNGE5NTRhOGZfcmVwb3J0c19hbHRlcl9jcm9udGFiX3NpemUucHk=) | `0.00% <0.00%> (ø)` | |
   | [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.48% <ø> (ø)` | |
   | [superset/tasks/scheduler.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | ... and [6 more](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=footer). Last update [9c8b65d...bb2a411](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12056: fix(reports): increase crontab size

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12056:
URL: https://github.com/apache/incubator-superset/pull/12056#issuecomment-745501290


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=h1) Report
   > Merging [#12056](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=desc) (d716bd0) into [master](https://codecov.io/gh/apache/incubator-superset/commit/832267c77650fad8a1f69666900ea37a2006ad5c?el=desc) (832267c) will **decrease** coverage by `0.12%`.
   > The diff coverage is `14.28%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12056/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12056      +/-   ##
   ==========================================
   - Coverage   63.81%   63.68%   -0.13%     
   ==========================================
     Files         954      957       +3     
     Lines       46774    46857      +83     
     Branches     4589     4590       +1     
   ==========================================
   - Hits        29849    29842       -7     
   - Misses      16741    16831      +90     
     Partials      184      184              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `62.67% <ø> (-0.05%)` | :arrow_down: |
   | python | `64.30% <14.28%> (-0.18%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ersions/ab104a954a8f\_reports\_alter\_crontab\_size.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hYjEwNGE5NTRhOGZfcmVwb3J0c19hbHRlcl9jcm9udGFiX3NpemUucHk=) | `0.00% <0.00%> (ø)` | |
   | [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.48% <ø> (ø)` | |
   | [superset/tasks/scheduler.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.47% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `100.00% <100.00%> (ø)` | |
   | [...perset-frontend/src/views/CRUD/alert/AlertList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvQWxlcnRMaXN0LnRzeA==) | `63.95% <0.00%> (-12.80%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.36% <0.00%> (-0.27%)` | :arrow_down: |
   | ... and [11 more](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=footer). Last update [832267c...d716bd0](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12056: fix(reports): increase crontab size and alert fixes

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12056:
URL: https://github.com/apache/incubator-superset/pull/12056#issuecomment-745501290


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=h1) Report
   > Merging [#12056](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=desc) (1a7fc55) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9c8b65d03fd7676f2600be89d19000b9756b4e2c?el=desc) (9c8b65d) will **decrease** coverage by `0.11%`.
   > The diff coverage is `12.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12056/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12056      +/-   ##
   ==========================================
   - Coverage   63.72%   63.60%   -0.12%     
   ==========================================
     Files         958      959       +1     
     Lines       47103    47117      +14     
     Branches     4609     4609              
   ==========================================
   - Hits        30016    29970      -46     
   - Misses      16903    16963      +60     
     Partials      184      184              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `62.66% <ø> (ø)` | |
   | python | `64.17% <12.50%> (-0.19%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ersions/ab104a954a8f\_reports\_alter\_crontab\_size.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hYjEwNGE5NTRhOGZfcmVwb3J0c19hbHRlcl9jcm9udGFiX3NpemUucHk=) | `0.00% <0.00%> (ø)` | |
   | [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.48% <ø> (ø)` | |
   | [superset/tasks/scheduler.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.81% <0.00%> (-8.59%)` | :arrow_down: |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.61% <0.00%> (-0.28%)` | :arrow_down: |
   | ... and [2 more](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=footer). Last update [9c8b65d...bb2a411](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] dpgaspar edited a comment on pull request #12056: fix(reports): increase crontab size

Posted by GitBox <gi...@apache.org>.
dpgaspar edited a comment on pull request #12056:
URL: https://github.com/apache/incubator-superset/pull/12056#issuecomment-745192658


   when CI finishes
   ![](https://giphy.com/gifs/pGkwaGc54Byx2/html5)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12056: fix(reports): increase crontab size

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12056:
URL: https://github.com/apache/incubator-superset/pull/12056#issuecomment-745501290


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=h1) Report
   > Merging [#12056](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=desc) (d716bd0) into [master](https://codecov.io/gh/apache/incubator-superset/commit/832267c77650fad8a1f69666900ea37a2006ad5c?el=desc) (832267c) will **decrease** coverage by `0.03%`.
   > The diff coverage is `14.28%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12056/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12056      +/-   ##
   ==========================================
   - Coverage   63.81%   63.77%   -0.04%     
   ==========================================
     Files         954      957       +3     
     Lines       46774    46857      +83     
     Branches     4589     4590       +1     
   ==========================================
   + Hits        29849    29885      +36     
   - Misses      16741    16788      +47     
     Partials      184      184              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `62.67% <ø> (-0.05%)` | :arrow_down: |
   | python | `64.44% <14.28%> (-0.04%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ersions/ab104a954a8f\_reports\_alter\_crontab\_size.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hYjEwNGE5NTRhOGZfcmVwb3J0c19hbHRlcl9jcm9udGFiX3NpemUucHk=) | `0.00% <0.00%> (ø)` | |
   | [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.48% <ø> (ø)` | |
   | [superset/tasks/scheduler.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.47% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `100.00% <100.00%> (ø)` | |
   | [...perset-frontend/src/views/CRUD/alert/AlertList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvQWxlcnRMaXN0LnRzeA==) | `63.95% <0.00%> (-12.80%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.49% <0.00%> (-0.14%)` | :arrow_down: |
   | ... and [15 more](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=footer). Last update [832267c...d716bd0](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12056: fix(reports): increase crontab size and alert fixes

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12056:
URL: https://github.com/apache/incubator-superset/pull/12056#issuecomment-745501290


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=h1) Report
   > Merging [#12056](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=desc) (1a7fc55) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9c8b65d03fd7676f2600be89d19000b9756b4e2c?el=desc) (9c8b65d) will **decrease** coverage by `0.37%`.
   > The diff coverage is `12.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12056/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12056      +/-   ##
   ==========================================
   - Coverage   63.72%   63.35%   -0.38%     
   ==========================================
     Files         958      959       +1     
     Lines       47103    47117      +14     
     Branches     4609     4609              
   ==========================================
   - Hits        30016    29849     -167     
   - Misses      16903    17084     +181     
     Partials      184      184              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `62.66% <ø> (ø)` | |
   | python | `63.76% <12.50%> (-0.60%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ersions/ab104a954a8f\_reports\_alter\_crontab\_size.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hYjEwNGE5NTRhOGZfcmVwb3J0c19hbHRlcl9jcm9udGFiX3NpemUucHk=) | `0.00% <0.00%> (ø)` | |
   | [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.48% <ø> (ø)` | |
   | [superset/tasks/scheduler.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
   | ... and [4 more](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=footer). Last update [9c8b65d...bb2a411](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12056: fix(reports): increase crontab size and alert fixes

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12056:
URL: https://github.com/apache/incubator-superset/pull/12056#issuecomment-745501290


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=h1) Report
   > Merging [#12056](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=desc) (bb2a411) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9c8b65d03fd7676f2600be89d19000b9756b4e2c?el=desc) (9c8b65d) will **decrease** coverage by `10.96%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12056/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #12056       +/-   ##
   ===========================================
   - Coverage   63.72%   52.75%   -10.97%     
   ===========================================
     Files         958      438      -520     
     Lines       47103    15746    -31357     
     Branches     4609     4077      -532     
   ===========================================
   - Hits        30016     8307    -21709     
   + Misses      16903     7439     -9464     
   + Partials      184        0      -184     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `52.75% <ø> (?)` | |
   | javascript | `?` | |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
   | [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
   | [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
   | [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
   | [...ontend/src/dashboard/util/getDashboardFilterKey.ts](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERhc2hib2FyZEZpbHRlcktleS50cw==) | `14.28% <0.00%> (-85.72%)` | :arrow_down: |
   | [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `8.00% <0.00%> (-84.00%)` | :arrow_down: |
   | [...nd/src/views/CRUD/data/query/QueryPreviewModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9xdWVyeS9RdWVyeVByZXZpZXdNb2RhbC50c3g=) | `14.70% <0.00%> (-82.97%)` | :arrow_down: |
   | ... and [861 more](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=footer). Last update [9c8b65d...bb2a411](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] dpgaspar commented on pull request #12056: fix(reports): increase crontab size

Posted by GitBox <gi...@apache.org>.
dpgaspar commented on pull request #12056:
URL: https://github.com/apache/incubator-superset/pull/12056#issuecomment-745192658


   when CI finishes
   https://gph.is/2d9n0sS
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12056: fix(reports): increase crontab size

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12056:
URL: https://github.com/apache/incubator-superset/pull/12056#issuecomment-745501290


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=h1) Report
   > Merging [#12056](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=desc) (d716bd0) into [master](https://codecov.io/gh/apache/incubator-superset/commit/832267c77650fad8a1f69666900ea37a2006ad5c?el=desc) (832267c) will **decrease** coverage by `0.13%`.
   > The diff coverage is `14.28%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12056/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12056      +/-   ##
   ==========================================
   - Coverage   63.81%   63.68%   -0.14%     
   ==========================================
     Files         954      957       +3     
     Lines       46774    46857      +83     
     Branches     4589     4590       +1     
   ==========================================
   - Hits        29849    29841       -8     
   - Misses      16741    16832      +91     
     Partials      184      184              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `62.67% <ø> (-0.05%)` | :arrow_down: |
   | python | `64.29% <14.28%> (-0.19%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ersions/ab104a954a8f\_reports\_alter\_crontab\_size.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hYjEwNGE5NTRhOGZfcmVwb3J0c19hbHRlcl9jcm9udGFiX3NpemUucHk=) | `0.00% <0.00%> (ø)` | |
   | [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.48% <ø> (ø)` | |
   | [superset/tasks/scheduler.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.47% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `100.00% <100.00%> (ø)` | |
   | [...perset-frontend/src/views/CRUD/alert/AlertList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvQWxlcnRMaXN0LnRzeA==) | `63.95% <0.00%> (-12.80%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
   | ... and [12 more](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=footer). Last update [832267c...d716bd0](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12056: fix(reports): increase crontab size and alert fixes

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12056:
URL: https://github.com/apache/incubator-superset/pull/12056#issuecomment-745501290


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=h1) Report
   > Merging [#12056](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=desc) (bb2a411) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9c8b65d03fd7676f2600be89d19000b9756b4e2c?el=desc) (9c8b65d) will **decrease** coverage by `10.49%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12056/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #12056       +/-   ##
   ===========================================
   - Coverage   63.72%   53.23%   -10.50%     
   ===========================================
     Files         958      438      -520     
     Lines       47103    15746    -31357     
     Branches     4609     4077      -532     
   ===========================================
   - Hits        30016     8382    -21634     
   + Misses      16903     7364     -9539     
   + Partials      184        0      -184     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `53.23% <ø> (?)` | |
   | javascript | `?` | |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
   | [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
   | [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
   | [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
   | [...ontend/src/dashboard/util/getDashboardFilterKey.ts](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERhc2hib2FyZEZpbHRlcktleS50cw==) | `14.28% <0.00%> (-85.72%)` | :arrow_down: |
   | [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `8.00% <0.00%> (-84.00%)` | :arrow_down: |
   | [...nd/src/views/CRUD/data/query/QueryPreviewModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9xdWVyeS9RdWVyeVByZXZpZXdNb2RhbC50c3g=) | `14.70% <0.00%> (-82.97%)` | :arrow_down: |
   | ... and [861 more](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=footer). Last update [9c8b65d...bb2a411](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io commented on pull request #12056: fix(reports): increase crontab size

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12056:
URL: https://github.com/apache/incubator-superset/pull/12056#issuecomment-745501290


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=h1) Report
   > Merging [#12056](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=desc) (d716bd0) into [master](https://codecov.io/gh/apache/incubator-superset/commit/832267c77650fad8a1f69666900ea37a2006ad5c?el=desc) (832267c) will **increase** coverage by `0.00%`.
   > The diff coverage is `14.28%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12056/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12056      +/-   ##
   ==========================================
     Coverage   63.81%   63.81%              
   ==========================================
     Files         954      474     -480     
     Lines       46774    29134   -17640     
     Branches     4589        0    -4589     
   ==========================================
   - Hits        29849    18593   -11256     
   + Misses      16741    10541    -6200     
   + Partials      184        0     -184     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `?` | |
   | python | `63.81% <14.28%> (-0.67%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ersions/ab104a954a8f\_reports\_alter\_crontab\_size.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hYjEwNGE5NTRhOGZfcmVwb3J0c19hbHRlcl9jcm9udGFiX3NpemUucHk=) | `0.00% <0.00%> (ø)` | |
   | [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.48% <ø> (ø)` | |
   | [superset/tasks/scheduler.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.47% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-3.87%)` | :arrow_down: |
   | ... and [498 more](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=footer). Last update [832267c...d716bd0](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12056: fix(reports): increase crontab size

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12056:
URL: https://github.com/apache/incubator-superset/pull/12056#issuecomment-745501290






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12056: fix(reports): increase crontab size and alert fixes

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12056:
URL: https://github.com/apache/incubator-superset/pull/12056#issuecomment-745501290


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=h1) Report
   > Merging [#12056](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=desc) (eed30f2) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5d9721e6bac8c8bc8f3e76326a16c65e097dbf6a?el=desc) (5d9721e) will **decrease** coverage by `4.45%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12056/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12056      +/-   ##
   ==========================================
   - Coverage   67.17%   62.72%   -4.46%     
   ==========================================
     Files         962      482     -480     
     Lines       47368    17830   -29538     
     Branches     4592     4629      +37     
   ==========================================
   - Hits        31820    11184   -20636     
   + Misses      15436     6462    -8974     
   - Partials      112      184      +72     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `62.72% <ø> (-0.02%)` | :arrow_down: |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...tend/src/dashboard/containers/DashboardBuilder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZEJ1aWxkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [635 more](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=footer). Last update [5d9721e...eed30f2](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12056: fix(reports): increase crontab size and alert fixes

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12056:
URL: https://github.com/apache/incubator-superset/pull/12056#issuecomment-745501290


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=h1) Report
   > Merging [#12056](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=desc) (1a7fc55) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9c8b65d03fd7676f2600be89d19000b9756b4e2c?el=desc) (9c8b65d) will **decrease** coverage by `0.40%`.
   > The diff coverage is `12.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12056/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12056      +/-   ##
   ==========================================
   - Coverage   63.72%   63.32%   -0.41%     
   ==========================================
     Files         958      959       +1     
     Lines       47103    47102       -1     
     Branches     4609     4609              
   ==========================================
   - Hits        30016    29826     -190     
   - Misses      16903    17092     +189     
     Partials      184      184              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `62.66% <ø> (ø)` | |
   | python | `63.72% <12.50%> (-0.65%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ersions/ab104a954a8f\_reports\_alter\_crontab\_size.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hYjEwNGE5NTRhOGZfcmVwb3J0c19hbHRlcl9jcm9udGFiX3NpemUucHk=) | `0.00% <0.00%> (ø)` | |
   | [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.48% <ø> (ø)` | |
   | [superset/tasks/scheduler.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | ... and [13 more](https://codecov.io/gh/apache/incubator-superset/pull/12056/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=footer). Last update [9c8b65d...bb2a411](https://codecov.io/gh/apache/incubator-superset/pull/12056?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org