[jira] [Commented] (YARN-3457) NPE when NodeManager.serviceInit fails and stopRecoveryStore called

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-3457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484813#comment-14484813 ] 

Hadoop QA commented on YARN-3457:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12723815/YARN-3457.001.patch
  against trunk revision ab04ff9.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.

Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7252//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7252//console

This message is automatically generated.

> NPE when NodeManager.serviceInit fails and stopRecoveryStore called
> -------------------------------------------------------------------
>
>                 Key: YARN-3457
>                 URL: https://issues.apache.org/jira/browse/YARN-3457
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>            Reporter: Bibin A Chundatt
>            Assignee: Bibin A Chundatt
>            Priority: Minor
>         Attachments: YARN-3457.001.patch
>
>
> When NodeManager service init fails during stopRecoveryStore null pointer exception is thrown
> {code}
>  @Override
>   protected void serviceInit(Configuration conf) throws Exception {
>    ..
>   try {
>       exec.init();
>     } catch (IOException e) {
>       throw new YarnRuntimeException("Failed to initialize container executor", e);
>     }    
> this.context = createNMContext(containerTokenSecretManager,
>         nmTokenSecretManager, nmStore);
>     
> {code}
> context is null when service init fails
> {code}
>   private void stopRecoveryStore() throws IOException {
>     nmStore.stop();
>     if (context.getDecommissioned() && nmStore.canRecover()) {
>    ..
>     }
>   }
> {code}
> Null pointer exception thrown
> {quote}
> 015-04-07 17:31:45,807 WARN org.apache.hadoop.service.AbstractService: When stopping the service NodeManager : java.lang.NullPointerException
> java.lang.NullPointerException
> 	at org.apache.hadoop.yarn.server.nodemanager.NodeManager.stopRecoveryStore(NodeManager.java:168)
> 	at org.apache.hadoop.yarn.server.nodemanager.NodeManager.serviceStop(NodeManager.java:280)
> 	at org.apache.hadoop.service.AbstractService.stop(AbstractService.java:221)
> 	at org.apache.hadoop.service.ServiceOperations.stop(ServiceOperations.java:52)
> 	at org.apache.hadoop.service.ServiceOperations.stopQuietly(ServiceOperations.java:80)
> 	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:171)
> 	at org.apache.hadoop.yarn.server.nodemanager.NodeManager.initAndStartNodeManager(NodeManager.java:484)
> 	at org.apache.hadoop.yarn.server.nodemanager.NodeManager.main(NodeManager.java:534)
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)