[jira] [Commented] (ARROW-16686) [C++] Use unique_ptr with FunctionOptions

["Antoine Pitrou (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-16686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17544748#comment-17544748 ] 

Antoine Pitrou commented on ARROW-16686:
----------------------------------------

Should it be a shared_ptr for flexibility, then?

> [C++] Use unique_ptr with FunctionOptions
> -----------------------------------------
>
>                 Key: ARROW-16686
>                 URL: https://issues.apache.org/jira/browse/ARROW-16686
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Vibhatha Lakmal Abeykoon
>            Assignee: Vibhatha Lakmal Abeykoon
>            Priority: Major
>
>  
> Update the usage of `FunctionOptions*` to `unique_ptr` 
> {code:java}
> /// \brief Configure a grouped aggregation
> struct ARROW_EXPORT Aggregate {  
> /// the name of the aggregation function  
> std::string function;
> /// options for the aggregation function  
> const FunctionOptions* options;
> }; {code}
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.7#820007)