You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by elsloo <gi...@git.apache.org> on 2017/02/01 18:51:01 UTC
[GitHub] incubator-trafficcontrol pull request #243: [TC-125] Lowercase FQDNs generat...
GitHub user elsloo opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/243
[TC-125] Lowercase FQDNs generated by Traffic Ops for use as DNSSEC k\u2026
\u2026ey names, and lowercase the corresponding usage on the Traffic Router side.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/elsloo/incubator-trafficcontrol 2.0.x_tr_dnssec_key_name_case_sensitivity
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/243.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #243
----
commit 4709fc4e971ce7287f4f3d1a950eab7b6c64fc2b
Author: Jeff Elsloo <je...@cable.comcast.com>
Date: 2017-02-01T18:49:37Z
[TC-125] Lowercase FQDNs generated by Traffic Ops for use as DNSSEC key names, and lowercase the corresponding usage on the Traffic Router side.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #243: [TC-125] Lowercase FQDNs generat...
Posted by mitchell852 <gi...@git.apache.org>.
Github user mitchell852 commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/243#discussion_r99145205
--- Diff: traffic_ops/app/lib/UI/DeliveryService.pm ---
@@ -78,7 +78,8 @@ sub get_cdn_domain {
distinct => 1
}
)->get_column('value')->single();
- return $cdn_domain;
+ # Always return a lowercase FQDN.
+ return lc($cdn_domain);
--- End diff --
does it make sense to lowercase the response from these methods too?
https://github.com/elsloo/incubator-trafficcontrol/blob/master/traffic_ops/app/lib/MojoPlugins/DeliveryService.pm#L213
https://github.com/elsloo/incubator-trafficcontrol/blob/master/traffic_ops/app/lib/MojoPlugins/DeliveryService.pm#L230
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #243: [TC-125] Lowercase FQDNs generat...
Posted by elsloo <gi...@git.apache.org>.
Github user elsloo commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/243#discussion_r99150356
--- Diff: traffic_ops/app/lib/UI/DeliveryService.pm ---
@@ -78,7 +78,8 @@ sub get_cdn_domain {
distinct => 1
}
)->get_column('value')->single();
- return $cdn_domain;
+ # Always return a lowercase FQDN.
+ return lc($cdn_domain);
--- End diff --
I did see those methods but from what I could tell they were not related to the paths that the DNSSEC stuff follows. I wanted to be surgical in the fix, rather than fixing every instance of things that might need to be lowercased.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #243: [TC-125] Lowercase FQDNs generat...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafficcontrol/pull/243
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---