You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/10/05 22:48:32 UTC

[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #6069: [Issue 6068] Fixing the calls to Helix to throw exception if zk conne…

Jackie-Jiang commented on pull request #6069:
URL: https://github.com/apache/incubator-pinot/pull/6069#issuecomment-703929767


   @mcvsubbu We want both `getChildNames()` and `getChildren()` to have the same behavior, and should throw exception on failures. Since Helix does not have the correct APIs for `getChildren()` yet, I would suggest not changing `getChildren()` for now and wait until we upgrade to the new Helix version, or it will be very confusing for the developers because of the unexpected Helix behavior. Thoughts?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org